Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Mon, 11 Sep 2017 11:34:21 -0700
changeset 662483 b79ae85ac4651a5be3dd0d4506626c9c56cd8069
parent 662482 f02a1818d98cd177c3ad18df8de05ca7a8fbaf3f
child 730880 50c92192aa9faa0dc8de47474b515789803a157a
push id79095
push userbgrinstead@mozilla.com
push dateMon, 11 Sep 2017 18:34:30 +0000
reviewerskmag
bugs1374837
milestone57.0a1
Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag This is working around an issue with Subprocess that affects some developers using a 32 bit build on a 64 bit Windows MozReview-Commit-ID: COsKOkBVjSZ
devtools/client/framework/ToolboxProcess.jsm
--- a/devtools/client/framework/ToolboxProcess.jsm
+++ b/devtools/client/framework/ToolboxProcess.jsm
@@ -272,16 +272,17 @@ BrowserToolboxProcess.prototype = {
     if (!system.constants.MOZILLA_OFFICIAL) {
       args.push("-purgecaches");
     }
 
     this._dbgProcessPromise = Subprocess.call({
       command,
       arguments: args,
       environmentAppend: true,
+      stderr: "stdout",
       environment: {
         // Disable safe mode for the new process in case this was opened via the
         // keyboard shortcut.
         MOZ_DISABLE_SAFE_MODE_KEY: "1",
       },
     }).then(proc => {
       this._dbgProcess = proc;