Bug 1398264 - position private browsing indicator and/or 10.9 fullscreen button to cope with the background on the toolbox, r?adw draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 11 Sep 2017 11:41:14 +0100
changeset 662352 1509b5ba882110adac993665a8740bbc1eaa94a7
parent 662313 f018e0fea5d684750a4b7c0c6e3326b1e1d11062
child 730826 4d1f3872c5cdda9b6b13cec41f5a8a3f00754779
push id79038
push usergijskruitbosch@gmail.com
push dateMon, 11 Sep 2017 12:16:43 +0000
reviewersadw
bugs1398264
milestone57.0a1
Bug 1398264 - position private browsing indicator and/or 10.9 fullscreen button to cope with the background on the toolbox, r?adw MozReview-Commit-ID: 27neu3DHqnp
browser/themes/osx/browser.css
browser/themes/windows/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -52,17 +52,24 @@
 }
 
 /** Begin titlebar **/
 
 #titlebar-buttonbox > .titlebar-button {
   display: none;
 }
 
-/* NB: these would be margin-inline-start/end if it wasn't for the fact that OS X
+/* Making the toolbox position:relative (browser.inc.css) occludes titlebar indicators
+ * if the toolbox has a background. Fix this by positioning the relevant elements, too: */
+#titlebar-secondary-buttonbox {
+  position: relative;
+  z-index: 1;
+}
+
+/* These would be margin-inline-start/end if it wasn't for the fact that OS X
  * doesn't reverse the order of the items in the titlebar in RTL mode. */
 .titlebar-placeholder[type="caption-buttons"],
 #titlebar-buttonbox {
   margin-left: 7px;
 }
 
 .titlebar-placeholder[type="fullscreen-button"],
 #titlebar-secondary-buttonbox {
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1094,16 +1094,19 @@ notification[value="translation"] {
 .private-browsing-indicator {
   display: none;
   pointer-events: none;
 }
 
 #private-browsing-indicator-titlebar {
   display: block;
   position: absolute;
+  /* Need to ensure this gets positioned on top of the position:relative #navigator-toolbox
+   * in case the dark/light themes give that item a background. */
+  z-index: 1;
 }
 
 #main-window[privatebrowsingmode=temporary][tabsintitlebar] #private-browsing-indicator-titlebar > .private-browsing-indicator {
   display: block;
 }
 
 #main-window[privatebrowsingmode=temporary]:-moz-any([inFullscreen],:not([tabsintitlebar])) #TabsToolbar > .private-browsing-indicator {
   display: -moz-box;