Bug 1398649: Capture the result from MigrateFrom25To26(). r?bkelly draft
authorTom Tung <shes050117@gmail.com>
Mon, 11 Sep 2017 14:57:06 +0800
changeset 662206 9ff331bd0dc1629a6a28b140611b175c25ee5cde
parent 662202 1b55231e6628e70f0c2ee2b2cb40a1e9861ac4b4
child 730782 e91451ee1e8197155641be023a785bda0e1e723a
push id78992
push userttung@mozilla.com
push dateMon, 11 Sep 2017 07:03:00 +0000
reviewersbkelly
bugs1398649
milestone57.0a1
Bug 1398649: Capture the result from MigrateFrom25To26(). r?bkelly MozReview-Commit-ID: DoVqSs53is5
dom/cache/DBSchema.cpp
--- a/dom/cache/DBSchema.cpp
+++ b/dom/cache/DBSchema.cpp
@@ -3179,17 +3179,17 @@ nsresult MigrateFrom25To26(mozIStorageCo
   // Add the response_padding_size column.
   // Note: only opaque repsonse should be non-null interger.
   nsresult rv = aConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
     "ALTER TABLE entries "
     "ADD COLUMN response_padding_size INTEGER NULL "
   ));
   if (NS_WARN_IF(NS_FAILED(rv))) { return rv; }
 
-  aConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
+  rv = aConn->ExecuteSimpleSQL(NS_LITERAL_CSTRING(
     "UPDATE entries SET response_padding_size = 0 "
       "WHERE response_type = 4" // opaque response
   ));
   if (NS_WARN_IF(NS_FAILED(rv))) { return rv; }
 
   rv = aConn->SetSchemaVersion(26);
   if (NS_WARN_IF(NS_FAILED(rv))) { return rv; }