Bug 1347833 - Add support to wrap long request parameters/cookies in the netmonitor sidebar. r=Honza draft
authorabhinav <abhinav.koppula@gmail.com>
Sun, 10 Sep 2017 00:08:06 +0530
changeset 661939 55ef5d7bc7bb0a94bcaaa5cfb9cc1e730796cd4d
parent 660738 37b95547f0d27565452136d16b2df2857be840f6
child 730708 500b27de1c05a6188f635a9b7355391dc303c2d9
push id78911
push userbmo:abhinav.koppula@gmail.com
push dateSat, 09 Sep 2017 18:38:55 +0000
reviewersHonza
bugs1347833
milestone57.0a1
Bug 1347833 - Add support to wrap long request parameters/cookies in the netmonitor sidebar. r=Honza MozReview-Commit-ID: LYQvQzxRC5G
devtools/client/netmonitor/src/assets/styles/netmonitor.css
devtools/client/netmonitor/src/components/properties-view.js
--- a/devtools/client/netmonitor/src/assets/styles/netmonitor.css
+++ b/devtools/client/netmonitor/src/assets/styles/netmonitor.css
@@ -780,16 +780,21 @@ body,
 .panel-container,
 .properties-view {
   display: flex;
   flex-direction: column;
   overflow-x: hidden;
   overflow-y: auto;
 }
 
+.panel-container .tree-container .objectBox {
+  white-space: normal;
+  word-wrap: break-word;
+}
+
 .properties-view {
   flex-grow: 1;
 }
 
 .properties-view .searchbox-section {
   flex: 0 1 auto;
 }
 
--- a/devtools/client/netmonitor/src/components/properties-view.js
+++ b/devtools/client/netmonitor/src/components/properties-view.js
@@ -45,25 +45,27 @@ const PropertiesView = createClass({
 
   propTypes: {
     object: PropTypes.object,
     enableInput: PropTypes.bool,
     expandableStrings: PropTypes.bool,
     filterPlaceHolder: PropTypes.string,
     sectionNames: PropTypes.array,
     openLink: PropTypes.func,
+    cropLimit: PropTypes.number
   },
 
   getDefaultProps() {
     return {
       enableInput: true,
       enableFilter: true,
       expandableStrings: false,
       filterPlaceHolder: "",
       sectionNames: [],
+      cropLimit: 1024
     };
   },
 
   getInitialState() {
     return {
       filterText: "",
     };
   },
@@ -116,20 +118,20 @@ const PropertiesView = createClass({
     // Put 2 here to not dup this method
     if (member.level === 0 && member.type === "object" ||
       (typeof member.value === "object" && member.value && member.value.value)) {
       return null;
     }
 
     return Rep(Object.assign(props, {
       // FIXME: A workaround for the issue in StringRep
-      // Force StringRep to crop the text everytime
+      // Force StringRep to crop the text every time
       member: Object.assign({}, member, { open: false }),
       mode: MODE.TINY,
-      cropLimit: 60,
+      cropLimit: this.props.cropLimit,
     }));
   },
 
   shouldRenderSearchBox(object) {
     return this.props.enableFilter && object && Object.keys(object)
       .filter((section) => !object[section][EDITOR_CONFIG_ID]).length > 0;
   },