Bug 1398231 - P1: Make file exist check before assertion. r?bkelly
MozReview-Commit-ID: 8t7P97Ttrv1
--- a/dom/cache/FileUtils.cpp
+++ b/dom/cache/FileUtils.cpp
@@ -781,18 +781,20 @@ LockedUpdateDirectoryPaddingFile(nsIFile
const bool aTemporaryFileExist)
{
MOZ_DIAGNOSTIC_ASSERT(aBaseDir);
MOZ_DIAGNOSTIC_ASSERT(aConn);
MOZ_DIAGNOSTIC_ASSERT(aIncreaseSize >= 0);
MOZ_DIAGNOSTIC_ASSERT(aDecreaseSize >= 0);
int64_t currentPaddingSize = 0;
- nsresult rv = LockedDirectoryPaddingGet(aBaseDir, ¤tPaddingSize);
- if (NS_WARN_IF(NS_FAILED(rv)) || aTemporaryFileExist) {
+ nsresult rv = NS_OK;
+ if (aTemporaryFileExist ||
+ NS_WARN_IF(NS_FAILED(rv =
+ LockedDirectoryPaddingGet(aBaseDir, ¤tPaddingSize)))) {
// Fail to read padding size from the dir padding file, so try to restore.
if (rv != NS_ERROR_FILE_NOT_FOUND &&
rv != NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) {
// Not delete the temporary padding file here, because we're going to
// overwrite it below anyway.
rv = LockedDirectoryPaddingDeleteFile(aBaseDir, DirPaddingFile::FILE);
if (NS_WARN_IF(NS_FAILED(rv))) { return rv; }
}