Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles; r?hiro; DONTBUILD draft
authorBrian Birtles <birtles@gmail.com>
Thu, 07 Sep 2017 16:24:12 +0900
changeset 660592 72641ee76a953357a00cb58b993a4316a86be618
parent 660422 d8e238b811d3dc74515065ae8cab6c74baf0295f
child 730288 e415c57278d6bb2e698e1d3d88f14d29cf543c74
push id78456
push userbmo:bbirtles@mozilla.com
push dateThu, 07 Sep 2017 07:32:04 +0000
reviewershiro, DONTBUILD
bugs1365855, 1209405, 1322970
milestone57.0a1
Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles; r?hiro; DONTBUILD Unlike GeckoRestyleManager::UpdateOnlyAnimationStyles which is called from *both* GeckoRestyleManager::ProcessPendingRestyles and FlushThrottledStyles, ServoRestyleManager::UpdateOnlyAnimationStyles is only called from FlushThrottledStyles which is what we use to update transform animations before doing hit-testing. In this case, there doesn't appear to be any situation where throttled SMIL animations need to be updated since SMIL animations are only throttled when they apply to display:none content (bug 1209405 and bug 1322970) in which case they should not affect hit testing. MozReview-Commit-ID: 4bt7hCSa7Xr
layout/base/ServoRestyleManager.cpp
--- a/layout/base/ServoRestyleManager.cpp
+++ b/layout/base/ServoRestyleManager.cpp
@@ -1200,17 +1200,16 @@ ServoRestyleManager::ProcessAllPendingAt
     Servo_ProcessInvalidations(StyleSet()->RawSet(), iter.Key(), &mSnapshots);
   }
   ClearSnapshots();
 }
 
 void
 ServoRestyleManager::UpdateOnlyAnimationStyles()
 {
-  // Bug 1365855: We also need to implement this for SMIL.
   bool doCSS = PresContext()->EffectCompositor()->HasPendingStyleUpdates();
   if (!doCSS) {
     return;
   }
 
   DoProcessPendingRestyles(ServoTraversalFlags::FlushThrottledAnimations);
 }