Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL; r?hiro draft
authorBrian Birtles <birtles@gmail.com>
Thu, 07 Sep 2017 15:50:21 +0900
changeset 660582 4547c911e02a65c7fee28d53581ff8bf67b5b856
parent 660422 d8e238b811d3dc74515065ae8cab6c74baf0295f
child 730279 be2fe7e9b0bb6cbd1087ab9c470c9cd1371d8098
push id78447
push userbmo:bbirtles@mozilla.com
push dateThu, 07 Sep 2017 07:16:02 +0000
reviewershiro
bugs1357296
milestone57.0a1
Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL; r?hiro I'm not sure exactly how this works, but test_smilTextZoom.xhtml passes so this appears to be taken care of. MozReview-Commit-ID: C04XjX2rtZw
dom/smil/nsSMILCSSValueType.cpp
--- a/dom/smil/nsSMILCSSValueType.cpp
+++ b/dom/smil/nsSMILCSSValueType.cpp
@@ -719,28 +719,16 @@ ValueFromStringHelper(nsCSSPropertyID aP
     return result;
   }
 
   // Compute value
   aPresContext->StyleSet()->AsServo()->GetAnimationValues(servoDeclarationBlock,
                                                           aTargetElement,
                                                           aStyleContext->AsServo(),
                                                           result);
-  if (result.IsEmpty()) {
-    return result;
-  }
-
-  if (aPropID == eCSSProperty_font_size) {
-    // FIXME (bug 1357296): Divide out text-zoom, since SVG is supposed to
-    // ignore it.
-    if (aPresContext->EffectiveTextZoom() != 1.0) {
-      NS_WARNING("stylo: Dividing out text-zoom not yet supported"
-                 " (bug 1357296)");
-    }
-  }
 
   return result;
 }
 
 // static
 void
 nsSMILCSSValueType::ValueFromString(nsCSSPropertyID aPropID,
                                     Element* aTargetElement,