Bug 1397609 - Fix a11y of bookmark star and Pocket urlbar buttons.
MozReview-Commit-ID: 30zJfz52uVB
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -908,27 +908,26 @@
<image id="pageActionButton"
class="urlbar-icon urlbar-page-action"
role="button"
tooltiptext="&pageActionButton.tooltip;"
onclick="BrowserPageActions.mainButtonClicked(event);"/>
<hbox id="star-button-box"
hidden="true"
class="urlbar-icon-wrapper urlbar-page-action"
- role="button"
context="pageActionPanelContextMenu"
oncontextmenu="BrowserPageActions.onContextMenu(event);"
onclick="BrowserPageActions.bookmark.onUrlbarNodeClicked(event);">
<image id="star-button"
class="urlbar-icon"
role="button"
observes="bookmarkThisPageBroadcaster"/>
<hbox id="star-button-animatable-box">
<image id="star-button-animatable-image"
- role="button"
+ role="presentation"
observes="bookmarkThisPageBroadcaster"/>
</hbox>
</hbox>
</hbox>
</textbox>
</toolbaritem>
<toolbaritem id="search-container" title="&searchItem.title;"
--- a/browser/extensions/pocket/bootstrap.js
+++ b/browser/extensions/pocket/bootstrap.js
@@ -114,17 +114,17 @@ var PocketPageAction = {
wrapper.setAttribute("context", "pageActionPanelContextMenu");
wrapper.addEventListener("contextmenu", event => {
window.BrowserPageActions.onContextMenu(event);
});
let animatableBox = doc.createElement("hbox");
animatableBox.id = "pocket-animatable-box";
let animatableImage = doc.createElement("image");
animatableImage.id = "pocket-animatable-image";
- animatableImage.setAttribute("role", "button");
+ animatableImage.setAttribute("role", "presentation");
let tooltip =
gPocketBundle.GetStringFromName("pocket-button.tooltiptext");
animatableImage.setAttribute("tooltiptext", tooltip);
let pocketButton = doc.createElement("image");
pocketButton.id = "pocket-button";
pocketButton.classList.add("urlbar-icon");
pocketButton.setAttribute("role", "button");
pocketButton.setAttribute("tooltiptext", tooltip);