Bug 1395920 - Remove vertical dividers in tabs tray page. r?nechen draft
authorJing-wei Wu <topwu.tw@gmail.com>
Tue, 05 Sep 2017 11:23:50 +0800
changeset 658885 62deeddcc77579419f6131cd4d0babcf982b291b
parent 658884 3f66400d8f5f6ec32303b995f2bd5c92ce3ed5f1
child 729787 1116cb313e95dea501b73ebce52b01fa6f18797f
push id77914
push userbmo:topwu.tw@gmail.com
push dateTue, 05 Sep 2017 03:29:46 +0000
reviewersnechen
bugs1395920
milestone57.0a1
Bug 1395920 - Remove vertical dividers in tabs tray page. r?nechen MozReview-Commit-ID: HZQcuSLbuOm
mobile/android/app/src/main/res/drawable-hdpi/tab_indicator_divider.9.png
mobile/android/app/src/main/res/drawable-xhdpi/tab_indicator_divider.9.png
mobile/android/app/src/main/res/layout/tabs_panel_default.xml
mobile/android/app/src/photon/res/values/dimens.xml
deleted file mode 100644
index f1338d8031ce95bd4ee12befcf44868e3ce293dd..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index f1338d8031ce95bd4ee12befcf44868e3ce293dd..0000000000000000000000000000000000000000
GIT binary patch
literal 0
Hc$@<O00001
--- a/mobile/android/app/src/main/res/layout/tabs_panel_default.xml
+++ b/mobile/android/app/src/main/res/layout/tabs_panel_default.xml
@@ -32,18 +32,16 @@
                 android:src="@drawable/tabs_panel_nav_back"
                 android:contentDescription="@string/back"
                 android:background="@drawable/action_bar_button_inverse"/>
 
             <org.mozilla.gecko.widget.IconTabWidget android:id="@+id/tab_widget"
                                                     android:layout_width="wrap_content"
                                                     android:layout_height="match_parent"
                                                     android:tabStripEnabled="false"
-                                                    android:divider="@drawable/tab_indicator_divider"
-                                                    android:dividerPadding="@dimen/tab_panel_divider_vertical_padding"
                                                     android:layout="@layout/tabs_panel_indicator"/>
 
             <View android:layout_width="0dip"
                   android:layout_height="match_parent"
                   android:layout_weight="1.0"/>
 
             <ImageButton android:id="@+id/add_tab"
                          style="@style/UrlBar.ImageButton"
--- a/mobile/android/app/src/photon/res/values/dimens.xml
+++ b/mobile/android/app/src/photon/res/values/dimens.xml
@@ -42,20 +42,16 @@
     <!-- If you update one of these values, update the others. -->
     <dimen name="tablet_nav_button_width">48dp</dimen>
     <dimen name="tablet_nav_button_width_half">21dp</dimen>
     <dimen name="tablet_nav_button_width_plus_half">36dp</dimen>
 
     <dimen name="tablet_fwd_button_padding_start">4dp</dimen>
     <dimen name="tablet_fwd_button_padding_end">4dp</dimen>
 
-    <!-- This is the system default for the vertical padding for the divider of the TabWidget.
-         Used to mimic the divider padding on the tablet tabs panel back button. -->
-    <dimen name="tab_panel_divider_vertical_padding">12dp</dimen>
-
     <dimen name="tablet_tab_strip_height">48dp</dimen>
     <dimen name="tablet_tab_strip_item_width">178dp</dimen>
     <dimen name="tablet_tab_strip_item_height">40dp</dimen>
     <dimen name="tablet_tab_strip_fading_edge_size">15dp</dimen>
     <dimen name="tablet_tab_strip_item_margin">0dp</dimen>
     <dimen name="tablet_tab_strip_divider_width">1dp</dimen>
     <dimen name="tablet_tab_strip_divider_height">30dp</dimen>
     <dimen name="tablet_tab_strip_divider_padding_bottom">4dp</dimen>