Bug 1396700 - Remove ServoStyleSet::UpdateStyleSheet(). draft
authorTing-Yu Lin <tlin@mozilla.com>
Fri, 01 Sep 2017 17:12:58 +0800
changeset 658878 e04bee92f6b35913206dfc5938cb206afd753396
parent 658877 e4b675c27df431489ac97e0ed9907d8de7881bf0
child 658879 328375670b80c90af54569291a579172ab99c84b
child 658891 539454bc519a6b7166affa0388181501ed270bdc
push id77912
push userbmo:tlin@mozilla.com
push dateTue, 05 Sep 2017 03:21:10 +0000
bugs1396700
milestone57.0a1
Bug 1396700 - Remove ServoStyleSet::UpdateStyleSheet(). This is no longer used. MozReview-Commit-ID: G7cUcz9CKeQ
layout/style/ServoStyleSet.cpp
layout/style/ServoStyleSet.h
--- a/layout/style/ServoStyleSet.cpp
+++ b/layout/style/ServoStyleSet.cpp
@@ -766,23 +766,16 @@ ServoStyleSet::InsertStyleSheetBefore(Sh
     Servo_StyleSet_InsertStyleSheetBefore(
         mRawSet.get(), aNewSheet, aReferenceSheet);
     SetStylistStyleSheetsDirty();
   }
 
   return NS_OK;
 }
 
-void
-ServoStyleSet::UpdateStyleSheet(ServoStyleSheet* aSheet)
-{
-  MOZ_ASSERT(aSheet);
-  // TODO(emilio): Get rid of this.
-}
-
 int32_t
 ServoStyleSet::SheetCount(SheetType aType) const
 {
   MOZ_ASSERT(nsStyleSet::IsCSSSheetType(aType));
   return mSheets[aType].Length();
 }
 
 ServoStyleSheet*
--- a/layout/style/ServoStyleSet.h
+++ b/layout/style/ServoStyleSet.h
@@ -233,21 +233,16 @@ public:
   nsresult PrependStyleSheet(SheetType aType, ServoStyleSheet* aSheet);
   nsresult RemoveStyleSheet(SheetType aType, ServoStyleSheet* aSheet);
   nsresult ReplaceSheets(SheetType aType,
                          const nsTArray<RefPtr<ServoStyleSheet>>& aNewSheets);
   nsresult InsertStyleSheetBefore(SheetType aType,
                                   ServoStyleSheet* aNewSheet,
                                   ServoStyleSheet* aReferenceSheet);
 
-  // Notify servo that the underlying raw sheet has changed, through cloning.
-  // This should only be called on a just-cloned sheet, because it does not
-  // mark the stylesheets as dirty either here or in servo.
-  void UpdateStyleSheet(ServoStyleSheet* aSheet);
-
   int32_t SheetCount(SheetType aType) const;
   ServoStyleSheet* StyleSheetAt(SheetType aType, int32_t aIndex) const;
 
   void AppendAllXBLStyleSheets(nsTArray<StyleSheet*>& aArray) const;
 
   template<typename Func>
   void EnumerateStyleSheetArrays(Func aCallback) const {
     for (const auto& sheetArray : mSheets) {