Bug 1393072 - Only tint light color for menu icons in private mode in large tablet. r?nechen draft
authorJing-wei Wu <topwu.tw@gmail.com>
Tue, 05 Sep 2017 10:27:18 +0800
changeset 658860 1cbf5f89238e2795bccbbe75a6917c473af1e8a3
parent 658859 377f49152a5373e4f4396e2b63cbf0106ed11aa1
child 658870 26035df56ccb6ec993cac69e5c228d70eb2b0ebf
push id77901
push userbmo:topwu.tw@gmail.com
push dateTue, 05 Sep 2017 02:30:22 +0000
reviewersnechen
bugs1393072, 272727
milestone57.0a1
Bug 1393072 - Only tint light color for menu icons in private mode in large tablet. r?nechen The tint logic for menu icons on different devices is: Normal mode: 1. Mobile & small tablet -> dark color(#272727) 2. Large tablet -> dark color(#272727) Private mode: 1. Mobile & small tablet -> dark color(#272727) 2. Large tablet -> light color(#38383D) MozReview-Commit-ID: 9cz53PieQHY
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -3715,17 +3715,17 @@ public class BrowserApp extends GeckoApp
         } else {
             return DrawableUtil.tintDrawable(this, R.drawable.ic_menu_bookmark_add, tint);
         }
     }
 
     private int resolveMenuIconTint(final boolean isPrivate) {
         final int tintResId;
 
-        if (isPrivate && HardwareUtils.isTablet()) {
+        if (isPrivate && HardwareUtils.isLargeTablet()) {
             tintResId = R.color.menu_item_tint_private;
         } else {
             tintResId = R.color.menu_item_tint;
         }
         return ResourcesCompat.getColor(getResources(), tintResId, null);
     }
 
     private int resolveBookmarkTitleID(final boolean isBookmark) {