Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE. draft
authorHenri Sivonen <hsivonen@hsivonen.fi>
Mon, 04 Sep 2017 16:50:39 +0300
changeset 658899 2db53c4dadcb3f9b9c5844fe5a6db3c5e42bdf45
parent 658644 ba819294022028176720e7880120af69c7a46222
child 729797 8c807c89e6e6398665499bc1a6395b47f93ecb75
push id77925
push userbmo:hsivonen@hsivonen.fi
push dateTue, 05 Sep 2017 05:36:14 +0000
bugs1396093
milestone57.0a1
Bug 1396093 - Add a missing leading zero byte to a test case that uses UTF-16BE. The old style system uses nsUnicharStreamLoader, which never signals the end of the stream to mozilla::Decoder, which caused the input to be truncated instead of the error in the input being detected. Stylo uses mozilla::css::StreamLoader, which correctly signals the end of the stream, so the an odd number of bytes in UTF-16BE resulted in the output ending with U+FFFD, which ran into the keyword "green" making it not a valid keyword. MozReview-Commit-ID: uSaCIfrAOF
layout/reftests/bugs/485012-1.html
layout/reftests/bugs/reftest.list
--- a/layout/reftests/bugs/485012-1.html
+++ b/layout/reftests/bugs/485012-1.html
@@ -2,15 +2,15 @@
 <html>
   <head>
     <style>
       body { color: red }
     </style>
     <script src="data:application/javascript,"></script>
     <link rel="stylesheet" type="text/css"
           charset="UTF-16BE"
-          href="data:text/css,%00b%00o%00d%00y%00{%00c%00o%00l%00o%00r%00:%00g%00r%00e%00e%00n}">
+          href="data:text/css,%00b%00o%00d%00y%00{%00c%00o%00l%00o%00r%00:%00g%00r%00e%00e%00n%00}">
   </head>
   <body>
     This should be green
   </body>
 </html>
-  
+
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@@ -1325,17 +1325,17 @@ random-if(d2d) == 482592-1a.xhtml 482592
 random-if(d2d) == 482592-1b.xhtml 482592-1-ref.html # bug 586771
 random-if(winWidget) fuzzy-if(skiaContent,1,5) == 482659-1a.html 482659-1-ref.html
 fuzzy-if(skiaContent,1,5) == 482659-1b.html 482659-1-ref.html
 fuzzy-if(skiaContent,1,5) == 482659-1c.html 482659-1-ref.html
 fuzzy-if(skiaContent,1,5) == 482659-1d.html 482659-1-ref.html
 == 483565.xul 483565-ref.xul
 == 484256-1.html 484256-1-ref.html
 == 484256-2.html 484256-1-ref.html
-fails-if(stylo||styloVsGecko) == 485012-1.html 485012-1-ref.html # bug 1396093
+== 485012-1.html 485012-1-ref.html
 == 485275-1.html 485275-1-ref.html
 == 485275-1.svg 485275-1-ref.html
 == 486052-1.html 486052-1-ref.html
 == 486052-2a.html 486052-2-ref.html
 == 486052-2b.html 486052-2-ref.html
 == 486052-2c.html 486052-2-ref.html
 == 486052-2d.html 486052-2-ref.html
 == 486052-2e.html 486052-2-ref.html