Bug 1389470 - disable rust parser on win32 due to OOM. r?kinetik draft
authorAlfredo.Yang <ayang@mozilla.com>
Mon, 04 Sep 2017 14:22:46 +0800
changeset 658462 1c1ad5e7c99a3e3bb0a5d44dd92b13367f04832f
parent 658358 8e05298328da75f3056a9f1f9609938870d756a0
child 729668 0c32244d1a4b8f6e35d98f08dd4c21b32aff8c30
push id77785
push userbmo:ayang@mozilla.com
push dateMon, 04 Sep 2017 07:09:01 +0000
reviewerskinetik
bugs1389470
milestone57.0a1
Bug 1389470 - disable rust parser on win32 due to OOM. r?kinetik MozReview-Commit-ID: L0lFXpbZtCX
dom/media/MediaPrefs.h
--- a/dom/media/MediaPrefs.h
+++ b/dom/media/MediaPrefs.h
@@ -189,19 +189,24 @@ private:
   DECL_MEDIA_PREF("media.flac.enabled",                       FlacEnabled, bool, true);
 
   // Hls
   DECL_MEDIA_PREF("media.hls.enabled",                        HLSEnabled, bool, false);
 
   // Both rust/stagefright will be enabled when this is true regardless of 'media.rust.mp4parser'.
   DECL_MEDIA_PREF("media.rust.test_mode",                     RustTestMode, bool, false);
 
+#if defined(XP_WIN) && !defined(_WIN64)
+  // Disable rust parser for win32 due to bug 1389470.
+  DECL_MEDIA_PREF("media.rust.mp4parser",                     EnableRustMP4Parser, bool, false);
+#else
   // True, it enables rust parser and fallback to stagefright if rust parser fails.
   // False, it uses stagefright only.
   DECL_MEDIA_PREF("media.rust.mp4parser",                     EnableRustMP4Parser, bool, true);
+#endif
 
   DECL_MEDIA_PREF("media.mp4.enabled",                        MP4Enabled, bool, false);
 
   // Error/warning handling, Decoder Doctor
   DECL_MEDIA_PREF("media.playback.warnings-as-errors",        MediaWarningsAsErrors, bool, false);
   DECL_MEDIA_PREF("media.playback.warnings-as-errors.stagefright-vs-rust",
                                                               MediaWarningsAsErrorsStageFrightVsRust, bool, false);