Bug 1396020 - Expose hard-coded strings in about:telemetry r?chutten draft
authorFrancesco Lodolo (:flod) <flod@lodolo.net>
Sat, 02 Sep 2017 09:27:12 +0200
changeset 657864 573a3ba70dcdd2675e6538a7869e093d82bc09b9
parent 657815 5278dfcf5eb9f58eaf06ad1ce67e7fd4aba34772
child 729547 7fc6b1a68e68380346bf4cb37becc26c08fca21c
push id77650
push userbmo:francesco.lodolo@gmail.com
push dateSat, 02 Sep 2017 07:28:06 +0000
reviewerschutten
bugs1396020
milestone57.0a1
Bug 1396020 - Expose hard-coded strings in about:telemetry r?chutten MozReview-Commit-ID: 1ddOE9cGX4Z
toolkit/content/aboutTelemetry.xhtml
toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
--- a/toolkit/content/aboutTelemetry.xhtml
+++ b/toolkit/content/aboutTelemetry.xhtml
@@ -23,23 +23,23 @@
   </head>
 
   <body id="body" dir="&locale.dir;">
 
     <div id="categories">
       <div class="heading">
         <span id="ping-type" class="change-ping dropdown"></span>
         <div id="controls" hidden="true">
-          <span id="older-ping">&lt;&lt;</span>
+          <span id="older-ping">&aboutTelemetry.previousPing;</span>
           <span id="ping-date" class="change-ping"></span>
-          <span id="newer-ping">&gt;&gt;</span>
+          <span id="newer-ping">&aboutTelemetry.nextPing;</span>
         </div>
       </div>
       <div id="category-home" class="category has-data selected" value="home-section">
-        <span class="category-name">Home</span>
+        <span class="category-name">&aboutTelemetry.homeSection;</span>
       </div>
       <div class="category" value="general-data-section">
         <span class="category-name">&aboutTelemetry.generalDataSection;</span>
       </div>
       <div class="category" value="environment-data-section">
         <span class="category-name">&aboutTelemetry.environmentDataSection;</span>
       </div>
       <div class="category" value="session-info-section">
--- a/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
+++ b/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
@@ -8,25 +8,31 @@
 <!ENTITY aboutTelemetry.showSubsessionData "Show subsession data">
 <!ENTITY aboutTelemetry.choosePing "Choose ping:">
 <!ENTITY aboutTelemetry.archivePingType "Ping Type">
 <!ENTITY aboutTelemetry.archivePingHeader "Ping">
 <!ENTITY aboutTelemetry.optionGroupToday "Today">
 <!ENTITY aboutTelemetry.optionGroupYesterday "Yesterday">
 <!ENTITY aboutTelemetry.optionGroupOlder "Older">
 <!ENTITY aboutTelemetry.payloadChoiceHeader "Payload">
+<!-- LOCALIZATION NOTE(aboutTelemetry.previousPing, aboutTelemetry.nextPing):
+	These strings are displayed when selecting Archived pings, and they’re
+	used to move to the next or previous ping. -->
+<!ENTITY aboutTelemetry.previousPing "&lt;&lt;">
+<!ENTITY aboutTelemetry.nextPing "&gt;&gt;">
 
 <!ENTITY aboutTelemetry.pageTitle "Telemetry Data">
 <!ENTITY aboutTelemetry.moreInformations "Looking for more information?">
 <!ENTITY aboutTelemetry.firefoxDataDoc "The <a>Firefox Data Documentation</a> contains guides about how to work with our data tools.">
 <!ENTITY aboutTelemetry.telemetryClientDoc "The <a>Firefox Telemetry client documentation</a> includes definitions for concepts, API documentation and data references.">
 <!ENTITY aboutTelemetry.telemetryDashboard "The <a>Telemetry dashboards</a> allow you to visualize the data Mozilla receives via Telemetry.">
 
 <!ENTITY aboutTelemetry.showInFirefoxJsonViewer "Open in the JSON viewer">
 
+<!ENTITY aboutTelemetry.homeSection "Home">
 <!ENTITY aboutTelemetry.generalDataSection "General Data">
 <!ENTITY aboutTelemetry.environmentDataSection "Environment Data">
 <!ENTITY aboutTelemetry.sessionInfoSection "Session Information">
 <!ENTITY aboutTelemetry.scalarsSection "Scalars">
 <!ENTITY aboutTelemetry.keyedScalarsSection "Keyed Scalars">
 <!ENTITY aboutTelemetry.histogramsSection "Histograms">
 <!ENTITY aboutTelemetry.keyedHistogramsSection "Keyed Histograms">
 <!ENTITY aboutTelemetry.eventsSection "Events">