Bug 1322746 - No fast uploads for x/y/zOffset!=0 yet. - r=daoshengmu draft
authorJeff Gilbert <jgilbert@mozilla.com>
Thu, 31 Aug 2017 13:38:23 -0700
changeset 656973 9ff39d8428f1c9c5538b052a394740c60ee774fe
parent 656972 f8d9f999103d0028f7db2506350977a286d721ef
child 656974 fa873cab27dc04174ec6177c147b9b83be0f9330
push id77391
push userbmo:jgilbert@mozilla.com
push dateThu, 31 Aug 2017 22:47:58 +0000
reviewersdaoshengmu
bugs1322746
milestone57.0a1
Bug 1322746 - No fast uploads for x/y/zOffset!=0 yet. - r=daoshengmu MozReview-Commit-ID: CVq6TYhg9FP
dom/canvas/TexUnpackBlob.cpp
--- a/dom/canvas/TexUnpackBlob.cpp
+++ b/dom/canvas/TexUnpackBlob.cpp
@@ -634,16 +634,20 @@ TexUnpackImage::TexOrSubImage(bool isSub
     }
 
     const char* fallbackReason;
     do {
         if (mDepth != 1) {
             fallbackReason = "depth is not 1";
             break;
         }
+        if (xOffset != 0 || yOffset != 0 || zOffset != 0) {
+            fallbackReason = "x/y/zOffset is not 0";
+            break;
+        }
 
         if (webgl->mPixelStore_UnpackSkipPixels ||
             webgl->mPixelStore_UnpackSkipRows ||
             webgl->mPixelStore_UnpackSkipImages)
         {
             fallbackReason = "non-zero UNPACK_SKIP_* not yet supported";
             break;
         }