Bug 1393274: Correct webpage RTL padding/margins. r=liuche
Previously, I added a comment to explain why the explicit 0dp padding/margins
are necessary for RTL but since it's required everywhere padding/margins are
used, it's unsustainable and I chose not to do it here.
MozReview-Commit-ID: H7H9xgeLy8b
--- a/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_webpage_item_row.xml
@@ -50,16 +50,18 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_toEndOf="@id/icon_wrapper"
android:layout_toLeftOf="@id/menu"
android:layout_toRightOf="@id/icon_wrapper"
android:layout_toStartOf="@id/menu"
android:paddingLeft="@dimen/activity_stream_base_margin"
android:paddingStart="@dimen/activity_stream_base_margin"
+ android:paddingRight="0dp"
+ android:paddingEnd="0dp"
android:paddingTop="@dimen/activity_stream_base_margin"
android:textAlignment="viewStart"
android:textColor="@color/activity_stream_subtitle"
android:textSize="12sp"
tools:text="twitter" />
<!-- See id/page_domain for textAlignment comment. -->
<TextView
@@ -70,16 +72,18 @@
android:layout_toEndOf="@id/icon_wrapper"
android:layout_toLeftOf="@id/menu"
android:layout_toRightOf="@id/icon_wrapper"
android:layout_toStartOf="@id/menu"
android:ellipsize="end"
android:maxLines="3"
android:paddingLeft="@dimen/activity_stream_base_margin"
android:paddingStart="@dimen/activity_stream_base_margin"
+ android:paddingRight="0dp"
+ android:paddingEnd="0dp"
android:textAlignment="viewStart"
android:textColor="#ff000000"
android:textSize="14sp"
android:textStyle="bold"
tools:text="Descriptive title of a page that is veeeeeeery long - maybe even too long?" />
<LinearLayout
android:layout_width="match_parent"
@@ -104,17 +108,20 @@
android:layout_height="12dp"
tools:src="@drawable/ic_as_bookmarked" />
<!-- See id/page_domain for textAlignment comment. -->
<TextView
android:id="@+id/page_source"
android:layout_width="0dp"
android:layout_height="wrap_content"
+ android:layout_marginStart="2dp"
android:layout_marginLeft="2dp"
+ android:layout_marginRight="0dp"
+ android:layout_marginEnd="0dp"
android:layout_weight="1"
android:textAlignment="viewStart"
android:textColor="@color/activity_stream_subtitle"
android:textSize="12sp"
tools:text="Bookmarked" />
</LinearLayout>
</RelativeLayout>