Bug 1230910 Fix 'error: narrowing conversion of '2148073472u' from 'unsigned int' to 'int' inside { }' draft
authorTom Ritter <tom@mozilla.com>
Wed, 08 Mar 2017 22:22:28 +0000
changeset 656094 3189cea122aa3d3ff3278845da9d90423e49fe51
parent 656093 b436c72c4ec1eedc1cf7d5fcf9875c65cd41bdb7
child 656095 6010f7b3e8b9685635ca997b52909583c407c737
push id77058
push userbmo:tom@mozilla.com
push dateWed, 30 Aug 2017 18:21:00 +0000
bugs1230910
milestone57.0a1
Bug 1230910 Fix 'error: narrowing conversion of '2148073472u' from 'unsigned int' to 'int' inside { }' MozReview-Commit-ID: IpS1qwG1LkM
security/sandbox/chromium/sandbox/win/src/restricted_token_utils.cc
security/sandbox/chromium/sandbox/win/src/sidestep/mini_disassembler_types.h
--- a/security/sandbox/chromium/sandbox/win/src/restricted_token_utils.cc
+++ b/security/sandbox/chromium/sandbox/win/src/restricted_token_utils.cc
@@ -60,17 +60,17 @@ DWORD CreateRestrictedToken(TokenLevel s
       deny_only_sids.push_back(WinBuiltinAdministratorsSid);
       deny_only_sids.push_back(WinAccountAdministratorSid);
       deny_only_sids.push_back(WinAccountDomainAdminsSid);
       deny_only_sids.push_back(WinAccountCertAdminsSid);
       deny_only_sids.push_back(WinAccountSchemaAdminsSid);
       deny_only_sids.push_back(WinAccountEnterpriseAdminsSid);
       deny_only_sids.push_back(WinAccountPolicyAdminsSid);
       deny_only_sids.push_back(WinBuiltinHyperVAdminsSid);
-      deny_only_sids.push_back(WinLocalAccountAndAdministratorSid);
+      //deny_only_sids.push_back(WinLocalAccountAndAdministratorSid);
       privilege_exceptions.push_back(SE_CHANGE_NOTIFY_NAME);
       break;
     }
     case USER_INTERACTIVE: {
       sid_exceptions.push_back(WinBuiltinUsersSid);
       sid_exceptions.push_back(WinWorldSid);
       sid_exceptions.push_back(WinInteractiveSid);
       sid_exceptions.push_back(WinAuthenticatedUserSid);
--- a/security/sandbox/chromium/sandbox/win/src/sidestep/mini_disassembler_types.h
+++ b/security/sandbox/chromium/sandbox/win/src/sidestep/mini_disassembler_types.h
@@ -122,19 +122,19 @@ struct SpecificOpcode {
   int table_index_;
 
   // The opcode type
   InstructionType type_;
 
   // Description of the type of the dest, src and aux operands,
   // put together from an enOperandType flag and an enAddressingMethod
   // flag.
-  int flag_dest_;
-  int flag_source_;
-  int flag_aux_;
+  unsigned int flag_dest_;
+  unsigned int flag_source_;
+  unsigned int flag_aux_;
 
   // We indicate the mnemonic for debugging purposes
   const char* mnemonic_;
 };
 
 // The information we keep in our tables about each of the different
 // valid instructions recognized by the IA-32 architecture.
 struct Opcode {
@@ -143,19 +143,19 @@ struct Opcode {
   int table_index_;
 
   // The opcode type
   InstructionType type_;
 
   // Description of the type of the dest, src and aux operands,
   // put together from an enOperandType flag and an enAddressingMethod
   // flag.
-  int flag_dest_;
-  int flag_source_;
-  int flag_aux_;
+  unsigned int flag_dest_;
+  unsigned int flag_source_;
+  unsigned int flag_aux_;
 
   // We indicate the mnemonic for debugging purposes
   const char* mnemonic_;
 
   // Alternative opcode info if certain prefixes are specified.
   // In most cases, all of these are zeroed-out.  Only used if
   // bPrefixDependent is true.
   bool is_prefix_dependent_;