Bug 1394391 - [tryselect] Split hg implementation of files_changed to a list, r?jhford
This fixes a regression from
bug 1384593. I was going to add a test for this, but it would be
a better use of time to fix
bug 1185599 and add a test there. We already have vcs tests in other
parts of the tree so consolidating them into a single module is likely easier than standing up
another one-off vcs tester.
MozReview-Commit-ID: E51Tb1qC9Wb
--- a/tools/tryselect/vcs.py
+++ b/tools/tryselect/vcs.py
@@ -143,17 +143,17 @@ class HgHelper(VCSHelper):
print(HG_PUSH_TO_TRY_NOT_FOUND)
return 1
finally:
self.run(['hg', 'revert', '-a'])
@property
def files_changed(self):
return self.run(['hg', 'log', '-r', '::. and not public()',
- '--template', '{join(files, "\n")}\n'])
+ '--template', '{join(files, "\n")}\n']).splitlines()
@property
def has_uncommitted_changes(self):
stat = [s for s in self.run(['hg', 'status', '-amrn']).split() if s]
return len(stat) > 0
class GitHelper(VCSHelper):