Bug 1394007 Fix a signedness comparison warning in WindowsDllBlocklist.cpp r?dmajor draft
authorTom Ritter <tom@mozilla.com>
Wed, 30 Aug 2017 00:43:46 -0500
changeset 655542 fc1f1ae74e3a136dd01c81603176cfd5dc53bae7
parent 655132 e23f95926a19ea9f1c659b9d953cfa96bcb9f3e6
child 728868 55187e4d0d03db2559b449651a13bb1320b6c8c8
push id76911
push userbmo:tom@mozilla.com
push dateWed, 30 Aug 2017 05:44:35 +0000
reviewersdmajor
bugs1394007
milestone57.0a1
Bug 1394007 Fix a signedness comparison warning in WindowsDllBlocklist.cpp r?dmajor MozReview-Commit-ID: 3qH0PU2gBur
mozglue/build/WindowsDllBlocklist.cpp
--- a/mozglue/build/WindowsDllBlocklist.cpp
+++ b/mozglue/build/WindowsDllBlocklist.cpp
@@ -515,17 +515,17 @@ DllBlockSet::Write(HANDLE file)
 
   // Because this method is called after a crash occurs, and uses heap memory,
   // protect this entire block with a structured exception handler.
   MOZ_SEH_TRY {
     DWORD nBytes;
     for (DllBlockSet* b = gFirst; b; b = b->mNext) {
       // write name[,v.v.v.v];
       WriteFile(file, b->mName, strlen(b->mName), &nBytes, nullptr);
-      if (b->mVersion != -1) {
+      if (b->mVersion != ALL_VERSIONS) {
         WriteFile(file, ",", 1, &nBytes, nullptr);
         uint16_t parts[4];
         parts[0] = b->mVersion >> 48;
         parts[1] = (b->mVersion >> 32) & 0xFFFF;
         parts[2] = (b->mVersion >> 16) & 0xFFFF;
         parts[3] = b->mVersion & 0xFFFF;
         for (int p = 0; p < 4; ++p) {
           char buf[32];