Bug 1393748 - Consolidate places sidebar styling. r?nhnt11 draft
authorDão Gottwald <dao@mozilla.com>
Fri, 25 Aug 2017 14:03:38 +0200
changeset 652915 2444242ca1bffa57e01aa5550042bead9a595350
parent 652914 3bbd8e25df3d92464b97bcb42413febd9041af6f
child 728228 375f3dba333fcc3b02e4ccccb1c1f19b3501e0b6
push id76205
push userdgottwald@mozilla.com
push dateFri, 25 Aug 2017 12:04:07 +0000
reviewersnhnt11
bugs1393748
milestone57.0a1
Bug 1393748 - Consolidate places sidebar styling. r?nhnt11 osx/places/places.css applies some useless styles #sidebar-search-container and #tabs-panel from the synced tabs sidebar which doesn't even use places.css. It also seems to overuse !important. windows/places/places.css makes an obsolete distinction between default and non-default themes when removing the tree's background and applies an obsolete custom background on Windows 7. MozReview-Commit-ID: 4y8V3Pc23TZ
browser/themes/osx/places/places.css
browser/themes/windows/places/places.css
--- a/browser/themes/osx/places/places.css
+++ b/browser/themes/osx/places/places.css
@@ -2,22 +2,19 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 %include ../shared.inc
 
 /* Sidebars */
 
 #bookmarksPanel,
-#history-panel,
-#sidebar-search-container,
-#tabs-panel {
-  -moz-appearance: none !important;
-  background-color: transparent !important;
-  border-top: none !important;
+#history-panel {
+  -moz-appearance: none;
+  background-color: transparent;
 }
 
 .sidebar-placesTree,
 .sidebar-placesTreechildren::-moz-tree-row {
   padding-bottom: 1px;
   margin: 0;
   height: 24px;
   font-size: 12px;
--- a/browser/themes/windows/places/places.css
+++ b/browser/themes/windows/places/places.css
@@ -10,16 +10,18 @@
 }
 
 #sidebar-search-container {
   padding: 4px;
 }
 
 .sidebar-placesTree {
   -moz-appearance: none;
+  background-color: transparent;
+  color: inherit;
   border: 0;
   margin: 0;
 }
 
 .sidebar-placesTreechildren::-moz-tree-cell,
 .sidebar-placesTreechildren::-moz-tree-twisty {
   padding: 0 4px;
 }
@@ -34,32 +36,19 @@
   text-decoration: underline;
 }
 
 .sidebar-placesTreechildren::-moz-tree-cell(separator) {
   cursor: default;
 }
 
 @media (-moz-windows-default-theme) {
-  .sidebar-placesTree {
-    background-color: transparent;
-    border-top: none;
-  }
-
   .sidebar-placesTreechildren::-moz-tree-cell-text(leaf, hover) {
     text-decoration: none;
   }
-
-  @media (-moz-os-version: windows-win7) {
-    #bookmarksPanel,
-    #history-panel,
-    #tabs-panel {
-      background-color: #EEF3FA;
-    }
-  }
 }
 
 /* Trees */
 
 %include ../../shared/places/tree-icons.inc.css
 
 /* Browser Sidebars */