bug 1385227, generate full update from l10n-stage directly, r=rail draft
authorAxel Hecht <axel@pike.org>
Tue, 22 Aug 2017 15:27:51 +0200 (2017-08-22)
changeset 696358 b3eb944a0cf423a4b0e22d8884fc90780a3bb109
parent 695799 41a66272bd113526fa1e533268ebd5bbf39f7532
child 696359 a8615003e101db4453fb49da1422f531133b3b87
push id88689
push useraxel@mozilla.com
push dateFri, 10 Nov 2017 14:37:37 +0000 (2017-11-10)
reviewersrail
bugs1385227
milestone58.0a1
bug 1385227, generate full update from l10n-stage directly, r=rail For regular builds, we build the mar from an unpackaged exe on windows. For repacks, we just built that from our l10n-stage directory, don't unpack again. MozReview-Commit-ID: 8gQ9G23RgzB
tools/update-packaging/Makefile.in
--- a/tools/update-packaging/Makefile.in
+++ b/tools/update-packaging/Makefile.in
@@ -23,19 +23,16 @@ MAR_BIN	= $(DIST)/host/bin/mar$(HOST_BIN
 MBSDIFF_BIN	= $(DIST)/host/bin/mbsdiff$(HOST_BIN_SUFFIX)
 
 OVERRIDE_DEFAULT_GOAL := full-update
 full-update:: complete-patch
 
 ifeq ($(OS_TARGET), WINNT)
 MOZ_PKG_FORMAT	:= SFX7Z
 UNPACKAGE	= '$(subst $(DIST),$(ABS_DIST),$(INSTALLER_PACKAGE))'
-ifdef AB_CD
-UNPACKAGE	= '$(PACKAGE_BASE_DIR)/$(PACKAGE)'
-endif
 endif
 
 include $(topsrcdir)/config/rules.mk
 include $(topsrcdir)/toolkit/mozapps/installer/signing.mk
 include $(topsrcdir)/toolkit/mozapps/installer/packager.mk
 
 ifdef MOZ_EXTERNAL_SIGNING_FORMAT
 # We can't use sha2signcode on mar files
@@ -47,21 +44,24 @@ ifndef MAR_OLD_FORMAT
 MAR_SIGN_FORMAT=mar_sha384
 else
 MAR_SIGN_FORMAT=mar
 endif
 
 dir-stage := $(call mkdir_deps,$(STAGE_DIR))
 
 complete-patch:: $(dir-stage)
+# unpack the windows installer, unless we're an l10n repack, we just packed this
+ifndef IS_LANGUAGE_REPACK
 ifeq ($(OS_TARGET), WINNT)
 	test -f $(UNPACKAGE)
 	$(RM) -rf '$(PACKAGE_DIR)'
 	cd $(PACKAGE_BASE_DIR) && $(INNER_UNMAKE_PACKAGE)
 endif
+endif
 	MAR=$(MAR_BIN) \
 	MOZ_PRODUCT_VERSION=$(MOZ_APP_VERSION) \
 	  $(srcdir)/make_full_update.sh \
 	  '$(DIST)/$(COMPLETE_MAR)' \
 	  '$(PACKAGE_DIR)'
 ifdef MOZ_SIGN_CMD
 	$(MOZ_SIGN_CMD) -f $(MAR_SIGN_FORMAT) '$(DIST)/$(COMPLETE_MAR)'
 endif