Bug 1393657 - Use mozfile.TemporaryDirectory; r?glandium draft
authorGregory Szorc <gps@mozilla.com>
Thu, 24 Aug 2017 18:32:05 -0700
changeset 652631 29fa1859266c75088b160c0de4154097a66396c4
parent 652630 c6641e054a48b44cc0db77cc2207e5d92720395c
child 652632 418f83e1c86d8889bcd0a3a3b2f40f4ea5536a8f
push id76102
push usergszorc@mozilla.com
push dateFri, 25 Aug 2017 01:57:05 +0000
reviewersglandium
bugs1393657
milestone57.0a1
Bug 1393657 - Use mozfile.TemporaryDirectory; r?glandium An inline comment wanted it. The change is trivial. MozReview-Commit-ID: CqyOYqNzwzr
build/pgo/profileserver.py
--- a/build/pgo/profileserver.py
+++ b/build/pgo/profileserver.py
@@ -1,21 +1,20 @@
 #!/usr/bin/python
 #
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import json
 import os
-import shutil
-import tempfile
 
 from buildconfig import substs
 from mozbuild.base import MozbuildObject
+from mozfile import TemporaryDirectory
 from mozhttpd import MozHttpd
 from mozprofile import FirefoxProfile, Profile, Preferences
 from mozprofile.permissions import ServerLocations
 from mozrunner import FirefoxRunner, CLI
 
 PORT = 8888
 
 if __name__ == '__main__':
@@ -27,19 +26,17 @@ if __name__ == '__main__':
                      docroot=os.path.join(build.topsrcdir, "build", "pgo"))
     httpd.start(block=False)
 
     locations = ServerLocations()
     locations.add_host(host='127.0.0.1',
                        port=PORT,
                        options='primary,privileged')
 
-    # TODO: mozfile.TemporaryDirectory
-    profilePath = tempfile.mkdtemp()
-    try:
+    with TemporaryDirectory() as profilePath:
         # TODO: refactor this into mozprofile
         prefpath = os.path.join(
             build.topsrcdir, "testing", "profiles", "prefs_general.js")
         prefs = {}
         prefs.update(Preferences.read_prefs(prefpath))
         interpolation = {"server": "%s:%d" % httpd.httpd.server_address,
                          "OOP": "false"}
         prefs = json.loads(json.dumps(prefs) % interpolation)
@@ -84,10 +81,8 @@ if __name__ == '__main__':
         runner = FirefoxRunner(profile=profile,
                                binary=build.get_binary_path(
                                    where="staged-package"),
                                cmdargs=cmdargs,
                                env=env)
         runner.start(debug_args=debug_args, interactive=interactive)
         runner.wait()
         httpd.stop()
-    finally:
-        shutil.rmtree(profilePath)