Bug 1392888 - [Form Autofill] Avoid using getElementsByTagName. r=MattN draft
authorLuke Chang <lchang@mozilla.com>
Thu, 24 Aug 2017 10:40:48 +0800
changeset 652677 772ad77d9137624c20bc52e3d203c3f9db855d6b
parent 651826 d1c70c20e7b52f7295411343e4dc5db8ee7c92b9
child 728135 d54157731c7f8c43ead3d57017096ee45546d28c
push id76107
push userbmo:lchang@mozilla.com
push dateFri, 25 Aug 2017 02:23:59 +0000
reviewersMattN
bugs1392888
milestone57.0a1
Bug 1392888 - [Form Autofill] Avoid using getElementsByTagName. r=MattN MozReview-Commit-ID: 7Km6xkR4ffq
browser/extensions/formautofill/FormAutofillHeuristics.jsm
--- a/browser/extensions/formautofill/FormAutofillHeuristics.jsm
+++ b/browser/extensions/formautofill/FormAutofillHeuristics.jsm
@@ -234,17 +234,17 @@ this.LabelUtils = {
     _extractLabelStrings(element);
     return strings;
   },
 
   generateLabelMap(doc) {
     let mappedLabels = new Map();
     let unmappedLabels = [];
 
-    for (let label of doc.getElementsByTagName("label")) {
+    for (let label of doc.querySelectorAll("label")) {
       let id = label.htmlFor;
       if (!id) {
         let control = label.control;
         if (!control) {
           continue;
         }
         id = control.id;
       }