Bug 1393229 - Stylo env vars must be a string value. r=jmaher draft
authorJ. Ryan Stinnett <jryans@gmail.com>
Wed, 23 Aug 2017 15:34:48 -0500
changeset 651590 d3de956448727b08d7e75cc22bf5d05f5bcd0f62
parent 651589 f63255f34f423c3b19db15d6195268fec476b92a
child 651591 a92d036263c7242c5d7cdee856ce181708c20348
child 652187 aa02444bd4d2e9de09f0e73ec87cdfe0c7397d2c
push id75772
push userbmo:jryans@gmail.com
push dateWed, 23 Aug 2017 21:26:48 +0000
reviewersjmaher
bugs1393229
milestone57.0a1
Bug 1393229 - Stylo env vars must be a string value. r=jmaher On at least macOS, it appears you have to ensure all environment values are strings only (not integers or other types). MozReview-Commit-ID: GONupRqugBs
testing/talos/talos/ttest.py
--- a/testing/talos/talos/ttest.py
+++ b/testing/talos/talos/ttest.py
@@ -89,21 +89,21 @@ class TTest(object):
         # in test.py configs
         here = os.path.dirname(os.path.realpath(__file__))
         if test_config['mainthread']:
             mainthread_io = os.path.join(here, "mainthread_io.log")
             setup.env['MOZ_MAIN_THREAD_IO_LOG'] = mainthread_io
 
         # As we transition to Stylo, we need to set env vars and output data properly
         if browser_config['stylo']:
-            setup.env['STYLO_FORCE_ENABLED'] = 1
+            setup.env['STYLO_FORCE_ENABLED'] = '1'
 
         # During the Stylo transition, measure different number of threads
         if browser_config.get('stylothreads', 0) > 0:
-            setup.env['STYLO_THREADS'] = browser_config['stylothreads']
+            setup.env['STYLO_THREADS'] = str(browser_config['stylothreads'])
 
         test_config['url'] = utils.interpolate(
             test_config['url'],
             profile=setup.profile_dir,
             firefox=browser_config['browser_path']
         )
 
         # setup global (cross-cycle) counters: