Bug 1391705 - don't show context menu except on toolbarbuttons on the main view, r?adw
MozReview-Commit-ID: GkGXAIrP15u
--- a/browser/base/content/browser-pageActions.js
+++ b/browser/base/content/browser-pageActions.js
@@ -590,16 +590,20 @@ var BrowserPageActions = {
* onContextMenuShowing.
*
* @param event (DOM event, required)
* The contextmenu event.
*/
onContextMenu(event) {
let node = event.originalTarget;
this._contextAction = this.actionForNode(node);
+ // Don't show the menu if there's no action where the user clicked!
+ if (!this._contextAction) {
+ event.preventDefault();
+ }
},
/**
* Call this on the context menu's popupshowing event.
*
* @param event (DOM event, required)
* The popupshowing event.
* @param popup (DOM node, required)
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -424,26 +424,26 @@
class="cui-widget-panel"
role="group"
type="arrow"
hidden="true"
flip="slide"
position="bottomcenter topright"
tabspecific="true"
noautofocus="true"
- context="pageActionPanelContextMenu"
- oncontextmenu="BrowserPageActions.onContextMenu(event);"
copyURL-title="©URLCmd.label;"
emailLink-title="&emailPageCmd.label;"
sendToDevice-title="&sendToDevice.label3;"
sendToDevice-notReadyTitle="&sendToDevice.syncNotReady.label;">
<photonpanelmultiview id="pageActionPanelMultiView"
mainViewId="pageActionPanelMainView"
viewCacheId="appMenu-viewCache">
<panelview id="pageActionPanelMainView"
+ context="pageActionPanelContextMenu"
+ oncontextmenu="BrowserPageActions.onContextMenu(event);"
class="PanelUI-subView">
<vbox class="panel-subview-body"/>
</panelview>
</photonpanelmultiview>
</panel>
<menupopup id="pageActionPanelContextMenu"
onpopupshowing="BrowserPageActions.onContextMenuShowing(event, this);">