Bug 1392622 - Remove the padding changes that bug 1352119 introduced since they aren't needed now that we're not sliding the tab title. Also, flip the translation of the animation when running in RTL. r?dao draft
authorJared Wein <jwein@mozilla.com>
Wed, 23 Aug 2017 00:03:56 -0400
changeset 653227 047bee8d75cf43bc2bfcd3b6a4afae277e76b608
parent 652136 892c8916ba32b7733e06bfbfdd4083ffae3ca028
child 728285 058a87c17d756109ccfd4f42d0178a986b379061
push id76268
push userbmo:jaws@mozilla.com
push dateFri, 25 Aug 2017 18:33:59 +0000
reviewersdao
bugs1392622, 1352119
milestone57.0a1
Bug 1392622 - Remove the padding changes that bug 1352119 introduced since they aren't needed now that we're not sliding the tab title. Also, flip the translation of the animation when running in RTL. r?dao MozReview-Commit-ID: FrrlIQsZCC8
browser/themes/shared/tabs.inc.css
--- a/browser/themes/shared/tabs.inc.css
+++ b/browser/themes/shared/tabs.inc.css
@@ -93,59 +93,59 @@
      however, that currently forces main thread painting. When this is fixed
      (after WebRender lands), we can do something like
      `transition: fill 0.333s, opacity 0.333s;` */
 
   fill: currentColor;
   opacity: 0.7;
 }
 
+:root[sessionrestored] .tab-throbber[busy]:-moz-locale-dir(rtl)::before {
+  animation-name: tab-throbber-animation-rtl;
+}
+
 @keyframes tab-throbber-animation {
   100% { transform: translateX(-100%); }
 }
 
+@keyframes tab-throbber-animation-rtl {
+  100% { transform: translateX(100%); }
+}
+
 :root[sessionrestored] .tab-throbber[progress]::before {
   fill: var(--tab-loading-fill);
   opacity: 1;
 }
 
 .tab-sharing-icon-overlay,
 .tab-icon-image {
   height: 16px;
   width: 16px;
 }
 
 .tab-throbber:not([pinned]),
 .tab-sharing-icon-overlay:not([pinned]),
 .tab-icon-image:not([pinned]) {
-  margin-inline-end: -16px;
+  margin-inline-end: 6px;
 }
 
 .tab-icon-image {
   list-style-image: url("chrome://mozapps/skin/places/defaultFavicon.svg");
 }
 
 .tab-icon-image[src^="chrome://"] {
   -moz-context-properties: fill;
   fill: currentColor;
 }
 
 .tab-icon-image[sharing]:not([selected]),
 .tab-sharing-icon-overlay {
   animation: 3s linear tab-sharing-icon-pulse infinite;
 }
 
-.tab-label-container {
-  padding-inline-start: 22px;
-}
-
-.tab-icon-image:not([src]):not([busy]):not([pinned]) ~ .tab-label-container {
-  padding-inline-start: 0;
-}
-
 /* This should remain identical to identity-box-sharing-icon-pulse in identity-block.inc.css */
 @keyframes tab-sharing-icon-pulse {
   0%, 16.66%, 83.33%, 100% {
     opacity: 0;
   }
   33.33%, 66.66% {
     opacity: 1;
   }