Bug 1391476 - Inline list append; r?dustin draft
authorGregory Szorc <gps@mozilla.com>
Mon, 21 Aug 2017 10:55:10 -0700
changeset 651402 535e7c45e6a58dff14660d33099184505213e767
parent 651339 6c40948045457afe248742bc4c8e152dbc7e3126
child 651403 2424c0d50d0e28b95d545a0606b99e2de09baf0d
push id75721
push usergszorc@mozilla.com
push dateWed, 23 Aug 2017 17:48:59 +0000
reviewersdustin
bugs1391476
milestone57.0a1
Bug 1391476 - Inline list append; r?dustin Static analysis in my editor was complaining about the old pattern. Why not fix it while I'm here. MozReview-Commit-ID: HtrGenolNXb
taskcluster/taskgraph/transforms/job/mozharness.py
--- a/taskcluster/taskgraph/transforms/job/mozharness.py
+++ b/taskcluster/taskgraph/transforms/job/mozharness.py
@@ -170,21 +170,20 @@ def mozharness_on_docker_worker_setup(co
     command = [
         '/home/worker/bin/run-task',
         # Various caches/volumes are default owned by root:root.
         '--chown-recursive', '/home/worker/workspace',
         '--chown-recursive', '/home/worker/tooltool-cache',
         '--vcs-checkout', '/home/worker/workspace/build/src',
         '--tools-checkout', '/home/worker/workspace/build/tools',
         '--',
+        '/home/worker/workspace/build/src/{}'.format(
+            run.get('job-script', 'taskcluster/scripts/builder/build-linux.sh')
+        ),
     ]
-    command.append("/home/worker/workspace/build/src/{}".format(
-        run.get('job-script',
-                "taskcluster/scripts/builder/build-linux.sh"
-                )))
 
     worker['command'] = command
 
 
 @run_job_using("generic-worker", "mozharness", schema=mozharness_run_schema)
 def mozharness_on_generic_worker(config, job, taskdesc):
     assert job['worker']['os'] == 'windows', 'only supports windows right now'