Bug 1392641 Check return value for functions declared with warn_unused_result
MozReview-Commit-ID: BJj3Lvtntd6
old mode 100644
new mode 100755
--- a/netwerk/base/BackgroundFileSaver.cpp
+++ b/netwerk/base/BackgroundFileSaver.cpp
@@ -903,17 +903,22 @@ BackgroundFileSaver::ExtractSignatureInf
certChainElement->pCertContext->pbCertEncoded),
certChainElement->pCertContext->cbCertEncoded);
rv = certDB->ConstructX509(certDER, getter_AddRefs(nssCert));
if (!nssCert) {
extractionSuccess = false;
LOG(("Couldn't create NSS cert [this = %p]", this));
break;
}
- nssCertList->AddCert(nssCert);
+ rv = nssCertList->AddCert(nssCert);
+ if (NS_FAILED(rv)) {
+ extractionSuccess = false;
+ LOG(("Couldn't add NSS cert to cert list [this = %p]", this));
+ break;
+ }
nsString subjectName;
nssCert->GetSubjectName(subjectName);
LOG(("Adding cert %s [this = %p]",
NS_ConvertUTF16toUTF8(subjectName).get(), this));
}
if (extractionSuccess) {
mSignatureInfo.AppendObject(nssCertList);
}
old mode 100644
new mode 100755
--- a/netwerk/protocol/http/nsHttpNTLMAuth.cpp
+++ b/netwerk/protocol/http/nsHttpNTLMAuth.cpp
@@ -346,17 +346,19 @@ nsHttpNTLMAuth::GenerateCredentials(nsIH
nsCOMPtr<nsIX509Cert> cert;
rv = status->GetServerCert(getter_AddRefs(cert));
if (NS_FAILED(rv))
return rv;
uint32_t length;
uint8_t* certArray;
- cert->GetRawDER(&length, &certArray);
+ rv = cert->GetRawDER(&length, &certArray);
+ if (NS_FAILED(rv))
+ return rv;
// If there is a server certificate, we pass it along the
// first time we call GetNextToken().
inBufLen = length;
inBuf = certArray;
} else {
// If there is no server certificate, we don't pass anything.
inBufLen = 0;
--- a/netwerk/system/win32/nsNotifyAddrListener.cpp
+++ b/netwerk/system/win32/nsNotifyAddrListener.cpp
@@ -208,17 +208,21 @@ bool nsNotifyAddrListener::findMac(char
nsAutoCString output;
SHA1Sum sha1;
nsCString combined(mac + addition);
sha1.update(combined.get(), combined.Length());
uint8_t digest[SHA1Sum::kHashSize];
sha1.finish(digest);
nsCString newString(reinterpret_cast<char*>(digest),
SHA1Sum::kHashSize);
- Base64Encode(newString, output);
+ nsresult rv = Base64Encode(newString, output);
+ if (NS_FAILED(rv)) {
+ found = false;
+ break;
+ }
LOG(("networkid: id %s\n", output.get()));
if (mNetworkId != output) {
// new id
Telemetry::Accumulate(Telemetry::NETWORK_ID, 1);
mNetworkId = output;
}
else {
// same id