Bug 1391177 - Part 9: Change indicator height in tabs tray page to 4dp. r?nechen,walkingice
MozReview-Commit-ID: JWzkvs0xJEo
--- a/mobile/android/app/src/photon/res/values-large/dimens.xml
+++ b/mobile/android/app/src/photon/res/values-large/dimens.xml
@@ -3,21 +3,16 @@
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<resources>
<dimen name="doorhanger_offsetY">100dp</dimen>
- <!-- This value is the height of the Tabs Panel header view
- (browser_toolbar_height) minus the height of the indicator
- (6dp). This value should change when the height of the view changes. -->
- <dimen name="tabs_panel_indicator_selected_padding_top">50dp</dimen>
-
<dimen name="browser_toolbar_height_flipper">@dimen/browser_toolbar_height</dimen>
<dimen name="browser_toolbar_button_padding">16dp</dimen>
<dimen name="browser_toolbar_icon_width">@dimen/browser_toolbar_height</dimen>
<dimen name="browser_toolbar_menu_radius">4dp</dimen>
<dimen name="browser_toolbar_favicon_size">16dp</dimen>
<dimen name="browser_toolbar_image_button_width">48dp</dimen>
<!-- ToolbarImageButton's pressed-highlight region is different from clickable region.
--- a/mobile/android/app/src/photon/res/values/dimens.xml
+++ b/mobile/android/app/src/photon/res/values/dimens.xml
@@ -16,18 +16,18 @@
<!-- ToolbarImageButton's pressed-highlight region is different from clickable region.
Our design is to make pressed-highlight region to be square. this vertical spacing value
helps drawable xml to set padding: (56 - 42) / 2 -->
<dimen name="browser_toolbar_image_button_v_spacing">7dp</dimen>
<dimen name="browser_toolbar_image_button_h_spacing">0dp</dimen>
<!-- This value is the height of the Tabs Panel header view
(browser_toolbar_height) minus the height of the indicator
- (6dp). This value should change when the height of the view changes. -->
- <dimen name="tabs_panel_indicator_selected_padding_top">50dp</dimen>
+ (4dp). This value should change when the height of the view changes. -->
+ <dimen name="tabs_panel_indicator_selected_padding_top">52dp</dimen>
<!-- We use two different values for browser_toolbar_height on tablet
which is inconsistent. Temporary value until bug 1150730 is fixed. -->
<dimen name="browser_toolbar_height_flipper">@dimen/browser_toolbar_height</dimen>
<dimen name="browser_toolbar_button_padding">12dp</dimen>
<dimen name="browser_toolbar_icon_width">48dp</dimen>
<dimen name="browser_toolbar_menu_icon_height">16dp</dimen>
<dimen name="browser_toolbar_menu_radius">2dp</dimen>