Bug 1387986 - Enable stroke-* test of test_transitions_per_property.html on Servo. r?birtles draft
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Tue, 22 Aug 2017 13:45:46 +0900
changeset 650271 f8d115c0058955d68d7a1e32b70f8e2dccfcfabe
parent 650228 128a79130ecd6f277190d031a623f991c73c5272
child 727350 1600dbed58055fb669d2f2f9cbe17af032de2d7e
push id75325
push userbmo:mantaroh@gmail.com
push dateTue, 22 Aug 2017 04:47:21 +0000
reviewersbirtles
bugs1387986
milestone57.0a1
Bug 1387986 - Enable stroke-* test of test_transitions_per_property.html on Servo. r?birtles MozReview-Commit-ID: 6OGzMPAEP6K
layout/style/test/test_transitions_per_property.html
--- a/layout/style/test/test_transitions_per_property.html
+++ b/layout/style/test/test_transitions_per_property.html
@@ -56,23 +56,16 @@ function any_unit_to_num(str)
 }
 
 var FUNC_NEGATIVE = "cubic-bezier(0.25, -2, 0.75, 1)";
 var FUNC_OVERONE = "cubic-bezier(0.25, 0, 0.75, 3)";
 
 // After resolving Bug 1387080, we can remove this variable.
 const isServo = SpecialPowers.DOMWindowUtils.isStyledByServo;
 
-// The following properties will be skipped while using Servo backend.
-var skippedProperties = {
-    "stroke-dasharray": true,       // Bug 1387986
-    "stroke-dashoffset": true,      // Bug 1369614
-    "stroke-width": true,           // Bug 1369614
-};
-
 var supported_properties = {
     "border-bottom-left-radius": [ test_radius_transition ],
     "border-bottom-right-radius": [ test_radius_transition ],
     "border-top-left-radius": [ test_radius_transition ],
     "border-top-right-radius": [ test_radius_transition ],
     "-moz-box-flex": [ test_float_zeroToOne_transition,
                        test_float_aboveOne_transition,
                        test_float_zeroToOne_clamped ],
@@ -983,21 +976,16 @@ function sample_array(array, count) {
   }
   return result;
 }
 
 // Test that transitions don't do anything (i.e., aren't supported) on
 // the properties not in our test list above (and not transition
 // properties themselves).
 for (prop in gCSSProperties) {
-  // Bug 1387080, we should remove this after passing all tests.
-  if (isServo && (prop in skippedProperties)) {
-    continue;
-  }
-
   var info = gCSSProperties[prop];
   if (!(prop in supported_properties) &&
       info.type != CSS_TYPE_TRUE_SHORTHAND &&
       !("alias_for" in info) &&
       !prop.match(/^transition-/) &&
       // FIXME (Bug 119078): THIS SHOULD REALLY NOT BE NEEDED!
       prop != "-moz-binding" &&
       prop != "mask") {
@@ -1066,21 +1054,16 @@ for (prop in gCSSProperties) {
 // Do 4-second linear transitions with -1 second transition delay and
 // linear timing function so that we can expect the transition to be
 // one quarter of the way through the value space right after changing
 // the property.
 div.style.setProperty("transition-duration", "4s", "");
 div.style.setProperty("transition-delay", "-1s", "");
 div.style.setProperty("transition-timing-function", "linear", "");
 for (prop in supported_properties) {
-  // Bug 1387080, we should remove this after passing all tests.
-  if (isServo && (prop in skippedProperties)) {
-    continue;
-  }
-
   var tinfo = supported_properties[prop];
   var info = gCSSProperties[prop];
 
   isnot(info.type, CSS_TYPE_TRUE_SHORTHAND,
         prop + " must not be a shorthand");
   if ("prerequisites" in info) {
     var prereqs = info.prerequisites;
     for (var prereq in prereqs) {