Bug 1390356: Do not focus AS context menu titles in Talkback. r=sebastian draft
authorMichael Comella <michael.l.comella@gmail.com>
Mon, 21 Aug 2017 14:40:30 -0700
changeset 650189 f13c2cc8e28f133fe267f8f08df16900dd711ba3
parent 650188 21b7312808389d8079c132bfa7dd79819463d82a
child 650190 a48ffccccb0c6a0fd2f9d42a7388da21c9d2936c
push id75295
push usermichael.l.comella@gmail.com
push dateTue, 22 Aug 2017 01:14:07 +0000
reviewerssebastian
bugs1390356
milestone57.0a1
Bug 1390356: Do not focus AS context menu titles in Talkback. r=sebastian MozReview-Commit-ID: GuFjd3XRMoS
mobile/android/app/src/main/res/layout/activity_stream_contextmenu_bottomsheet.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_contextmenu_bottomsheet.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_contextmenu_bottomsheet.xml
@@ -1,26 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <LinearLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
-    xmlns:gecko="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:orientation="vertical">
 
+    <!-- a11y: When the dialog first appears, the title is announced so there is no
+         need to allow refocusing the title. -->
     <RelativeLayout
         android:id="@+id/info_wrapper"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:padding="10dp">
+        android:padding="10dp"
+        android:importantForAccessibility="noHideDescendants">
 
         <org.mozilla.gecko.activitystream.homepanel.stream.StreamOverridablePageIconLayout
                 android:id="@+id/page_icon_layout"
                 android:layout_width="@dimen/favicon_bg"
                 android:layout_height="@dimen/favicon_bg"
                 android:layout_gravity="center"
                 tools:background="@drawable/favicon_globe"/>