Bug 1390916 - Make .PHONY rule match the actual make targets; r?gps draft
authorMike Shal <mshal@mozilla.com>
Thu, 10 Aug 2017 14:58:04 -0400
changeset 649958 c5e2e4de901cb2d8393f653d487fbbae0bde0cba
parent 649871 c7c96eebbcb91e5e0c8ef0dbbb5324812fa1e476
child 649959 b62a49c2bac4846912f2701ba2f8df7f0225be25
push id75219
push userbmo:mshal@mozilla.com
push dateMon, 21 Aug 2017 15:45:59 +0000
reviewersgps
bugs1390916
milestone57.0a1
Bug 1390916 - Make .PHONY rule match the actual make targets; r?gps MozReview-Commit-ID: Gy4YrUtaB5H
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -170,17 +170,17 @@ NO_REMOVE=1
 endif
 
 # For an artifact build, _tests will already be partly populated, so run
 # this install manifest with NO_REMOVE set in this case.
 ifdef MOZ_ARTIFACT_BUILDS
 install-_tests: NO_REMOVE=1
 endif
 
-.PHONY: $(addprefix install-,$(subst /,_,$(install_manifests)))
+.PHONY: $(addprefix install-,$(install_manifests))
 $(addprefix install-,$(install_manifests)): install-%: $(install_manifest_depends)
 ifneq (,$(filter FasterMake+RecursiveMake,$(BUILD_BACKENDS)))
 	@# If we're using the hybrid FasterMake/RecursiveMake backend, we want
 	@# to ensure the FasterMake end doesn't have install manifests for the
 	@# same directory, because that would blow up
 	$(if $(wildcard _build_manifests/install/$(subst /,_,$*)),$(if $(wildcard faster/install_$(subst /,_,$*)*),$(error FasterMake and RecursiveMake ends of the hybrid build system want to handle $*)))
 endif
 	$(addprefix $(call py_action,process_install_manifest,$(if $(NO_REMOVE),--no-remove )$*) ,$(wildcard _build_manifests/install/$(subst /,_,$*)))