Bug 1388170 - Page Action Menu > Pocket needs to read "Save to Pocket". r?Gijs draft
authorDrew Willcoxon <adw@mozilla.com>
Wed, 16 Aug 2017 15:02:07 -0700
changeset 647729 a206d2fd1c3d7d5fa72a13b89203d98a81492390
parent 647604 138c8ebcbb6f99fd5a9e18767a6dd30040dced41
child 726626 5c8280b5cf12b4c8b62f948ca01f1c8155e8ca67
push id74532
push userdwillcoxon@mozilla.com
push dateWed, 16 Aug 2017 22:03:32 +0000
reviewersGijs
bugs1388170
milestone57.0a1
Bug 1388170 - Page Action Menu > Pocket needs to read "Save to Pocket". r?Gijs MozReview-Commit-ID: KRK3GYion1t
browser/base/content/browser.xul
browser/extensions/pocket/bootstrap.js
browser/locales/en-US/chrome/browser/browser.dtd
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -449,17 +449,17 @@
            photon="true"
            position="bottomcenter topright"
            tabspecific="true"
            noautofocus="true"
            context="pageActionPanelContextMenu"
            oncontextmenu="BrowserPageActions.onContextMenu(event);"
            copyURL-title="&copyURLCmd.label;"
            emailLink-title="&emailPageCmd.label;"
-           sendToDevice-title="&sendToDevice.label2;"
+           sendToDevice-title="&sendToDevice.label3;"
            sendToDevice-notReadyTitle="&sendToDevice.syncNotReady.label;">
       <photonpanelmultiview id="pageActionPanelMultiView"
                             mainViewId="pageActionPanelMainView"
                             viewCacheId="appMenu-viewCache">
         <panelview id="pageActionPanelMainView"
                    class="PanelUI-subView">
           <vbox class="panel-subview-body"/>
         </panelview>
--- a/browser/extensions/pocket/bootstrap.js
+++ b/browser/extensions/pocket/bootstrap.js
@@ -88,17 +88,17 @@ var PocketPageAction = {
   },
 
   init() {
     let id = "pocket";
     this.pageAction = PageActions.actionForID(id);
     if (!this.pageAction) {
       this.pageAction = PageActions.addAction(new PageActions.Action({
         id,
-        title: gPocketBundle.GetStringFromName("pocket-button.label"),
+        title: gPocketBundle.GetStringFromName("saveToPocketCmd.label"),
         shownInUrlbar: true,
         wantsIframe: true,
         urlbarIDOverride: "pocket-button-box",
         anchorIDOverride: "pocket-button",
         _insertBeforeActionID: PageActions.ACTION_ID_BOOKMARK_SEPARATOR,
         _urlbarNodeInMarkup: true,
         onBeforePlacedInWindow(window) {
           let doc = window.document;
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd
@@ -991,10 +991,10 @@ you can use these alternative items. Oth
 <!ENTITY updateRestart.cancelButton.label "Not Now">
 <!ENTITY updateRestart.cancelButton.accesskey "N">
 <!ENTITY updateRestart.panelUI.label2 "Restart to update &brandShorterName;">
 
 <!ENTITY pageActionButton.tooltip "Page actions">
 <!ENTITY pageAction.addToUrlbar.label "Add to Address Bar">
 <!ENTITY pageAction.removeFromUrlbar.label "Remove from Address Bar">
 
-<!ENTITY sendToDevice.label2 "Send to Device">
+<!ENTITY sendToDevice.label3 "Send Page to Device">
 <!ENTITY sendToDevice.syncNotReady.label "Syncing Devices…">