Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel, r?Gijs draft
authorFischer.json <fischer.json@gmail.com>
Wed, 16 Aug 2017 15:22:24 +0800
changeset 647399 f62c34345ba0a6a22d9052f3ad0314197d7b5489
parent 647200 4e93516e92e58d166ad37b8544c3230024afb587
child 726480 75646b27bc9bb4b39390844280ef4c382802b628
push id74382
push userbmo:fliu@mozilla.com
push dateWed, 16 Aug 2017 08:09:09 +0000
reviewersGijs
bugs1390767
milestone57.0a1
Bug 1390767 - UITour shouldn't put rounded-corner highlight on targets in the page action panel, r?Gijs MozReview-Commit-ID: LYVc3kRPEfZ
browser/components/uitour/UITour.jsm
--- a/browser/components/uitour/UITour.jsm
+++ b/browser/components/uitour/UITour.jsm
@@ -1143,17 +1143,17 @@ this.UITour = {
       highlighter.parentElement.setAttribute("targetName", aTarget.targetName);
       highlighter.parentElement.hidden = false;
 
       let highlightAnchor = aAnchorEl;
       let targetRect = highlightAnchor.getBoundingClientRect();
       let highlightHeight = targetRect.height;
       let highlightWidth = targetRect.width;
 
-      if (this.targetIsInAppMenu(aTarget)) {
+      if (this.targetIsInAppMenu(aTarget) || this.targetIsInPageActionPanel(aTarget)) {
         highlighter.classList.remove("rounded-highlight");
       } else {
         highlighter.classList.add("rounded-highlight");
       }
       if (highlightAnchor.classList.contains("toolbarbutton-1") &&
           highlightAnchor.getAttribute("cui-areatype") === "toolbar" &&
           highlightAnchor.getAttribute("overflowedItem") !== "true") {
         // A toolbar button in navbar has its clickable area an