Bug 1389637: Enable Top Site scrolling when dragging TextView. r=sebastian draft
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 15 Aug 2017 14:42:13 -0700
changeset 646968 42315bd56082c263bce7a208f5dd4777b1f4f168
parent 646884 7ff4c2f1fe11f6b98686f783294692893b1e1e8b
child 726375 08da5959478313e72b8ae5080e3768114a2e7de7
push id74265
push usermichael.l.comella@gmail.com
push dateTue, 15 Aug 2017 21:43:36 +0000
reviewerssebastian
bugs1389637
milestone57.0a1
Bug 1389637: Enable Top Site scrolling when dragging TextView. r=sebastian As per SO, singleLine also needed to be removed because it automatically sets scrollHorizontally=true. MozReview-Commit-ID: 89AL31Niv4L
mobile/android/app/src/main/res/layout/activity_stream_topsites_card.xml
--- a/mobile/android/app/src/main/res/layout/activity_stream_topsites_card.xml
+++ b/mobile/android/app/src/main/res/layout/activity_stream_topsites_card.xml
@@ -11,25 +11,27 @@
         android:id="@+id/favicon"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         gecko:enableRoundCorners="false"
         tools:background="@drawable/favicon_globe"
         android:scaleType="centerInside"
         gecko:overrideScaleType="false" />
 
+    <!-- scrollHorizontally=false allows drags on the TextView to scroll the ViewPager.
+         See https://stackoverflow.com/a/18171834/2219998 -->
     <TextView
         android:id="@+id/title"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:background="#66000000"
         android:padding="5dp"
         android:drawablePadding="2dp"
         android:maxLines="1"
-        android:singleLine="true"
         android:ellipsize="end"
         android:gravity="center"
         android:textColor="@android:color/white"
         android:textSize="12sp"
         android:layout_gravity="bottom"
+        android:scrollHorizontally="false"
         tools:text="Lorem Ipsum here is a title" />
 
 </FrameLayout>