Bug 1390520 - Enable Set Window Rect from minimized window state test. r?automatedtester draft
authorAndreas Tolfsen <ato@sny.no>
Tue, 15 Aug 2017 15:57:34 +0100
changeset 646600 47a1bbc6f9a5d17ed473c57d8d0d1bd0303d2b6d
parent 646498 564e82f0f289af976da01c2d50507017bbc152b5
child 646601 4d01aa2c21722fc3b8f767fd517c72acf9fe235f
push id74187
push userbmo:ato@sny.no
push dateTue, 15 Aug 2017 15:36:11 +0000
reviewersautomatedtester
bugs1390520
milestone57.0a1
Bug 1390520 - Enable Set Window Rect from minimized window state test. r?automatedtester Now that geckodriver has support for window state in the window rect object, we can enable the test_set_window_rect_window_minimized test from testing/web-platform/tests/webdriver/tests/set_window_rect.py. MozReview-Commit-ID: FY6EZTxMUbE
testing/web-platform/meta/MANIFEST.json
testing/web-platform/meta/webdriver/tests/set_window_rect.py.ini
testing/web-platform/tests/webdriver/tests/set_window_rect.py
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -482892,17 +482892,17 @@
    "fb4b7b86ff4b56d001b6ffe72f6d9c8a91046d2c",
    "support"
   ],
   "css/CSS2/tables/reference/table-anonymous-border-spacing-ref.xht": [
    "157b21a9f2954094ec5e682c3d131f320b6473a2",
    "support"
   ],
   "css/CSS2/tables/reference/table-anonymous-text-indent-ref.xht": [
-   "d12237ecbbd205dd38d956aacc6c1a50ee5631bb",
+   "40d1dfe3486108892a7d6ff61bc99196730bcb55",
    "support"
   ],
   "css/CSS2/tables/reference/table-margin-004-ref.xht": [
    "cb0ab88ee6938c670cdb7140781d13173f759b41",
    "support"
   ],
   "css/CSS2/tables/row-visibility-001.xht": [
    "5f8962c6026581ddd659cb96617f79330ccae7ed",
@@ -484084,17 +484084,17 @@
    "3b5ced13b1370794b069c5431252dc370257a242",
    "visual"
   ],
   "css/CSS2/tables/table-anonymous-objects-210.xht": [
    "516b5f1e6cec15bc53aef58f1eb41973c46e7190",
    "visual"
   ],
   "css/CSS2/tables/table-anonymous-text-indent.xht": [
-   "e6aea4bbc5ce33d6ec4ae570501fb5493dbc49f0",
+   "57bfe388308a128e32abc674b64acbf9903d6141",
    "reftest"
   ],
   "css/CSS2/tables/table-anonymous-whitespace-001.xht": [
    "50b8874d4b4b1fbcde591344235be17ce7e4138f",
    "visual"
   ],
   "css/CSS2/tables/table-background-edge-and-border-model-001.xht": [
    "58a9cbd54e49d76742a85730d929cb3d43f0eea9",
@@ -572512,21 +572512,21 @@
    "4d8c4ddb997d85ca2c971602a3096f57565c01eb",
    "testharness"
   ],
   "cssom-view/elementFromPoint-001.html": [
    "bf1c490777f450275a95ecfc6d6d2c0d055aca82",
    "testharness"
   ],
   "cssom-view/elementFromPoint-002.html": [
-   "36b8a5f50e6489f9e25c3d09dc523007d442e2b3",
+   "36d7e75021f7f6ab8f89b2654ba3c8f818af16b8",
    "testharness"
   ],
   "cssom-view/elementFromPoint-003.html": [
-   "36b8a5f50e6489f9e25c3d09dc523007d442e2b3",
+   "a689737bd60877e181a8a7ff27774ab383c3de0b",
    "testharness"
   ],
   "cssom-view/elementFromPoint.html": [
    "0f78405640523cf451b19ea0348b8216139b8168",
    "testharness"
   ],
   "cssom-view/elementFromPosition.html": [
    "d90dff8b15ec2977f341a7add9c7d627b62d9d0f",
@@ -578620,17 +578620,17 @@
    "af2c7b4ca07ae6c74d261bc745e174df8ab3ffef",
    "support"
   ],
   "fetch/api/resources/trickle.py": [
    "adb1bc80366cf924cfe13f6c73555d999d1d8e4f",
    "support"
   ],
   "fetch/api/resources/utils.js": [
-   "1027bd5e728ae008520ce151722760dbb53a2368",
+   "d9e65bbd408a906a4d14aa40d4ed20ea2ed9f585",
    "support"
   ],
   "fetch/api/response/multi-globals/current/current.html": [
    "2d9ab238e07a88d19365f78bfd5db84d32854de1",
    "support"
   ],
   "fetch/api/response/multi-globals/incumbent/incumbent.html": [
    "64b0018883b2ff64e0ea9183b7d513834c4174a4",
@@ -578652,17 +578652,17 @@
    "4fde2d5591959ef413f5f5695a8eebd6cb193fff",
    "testharness"
   ],
   "fetch/api/response/response-consume-empty.html": [
    "a9606b70a21e24dde0da19656773fc0c60fa255f",
    "testharness"
   ],
   "fetch/api/response/response-consume-stream.html": [
-   "dad05becbd8f3944aa3709ae1a3e578c05d4d935",
+   "7e990d212ef225ac8475803e01b1772086dbc08d",
    "testharness"
   ],
   "fetch/api/response/response-consume.html": [
    "936272bddf1a090267343fc7f8ab3669da98d27d",
    "testharness"
   ],
   "fetch/api/response/response-error.html": [
    "06489e75d56cbbdbfee903bea7e39c549310ba3e",
@@ -596280,17 +596280,17 @@
    "fda57b55aabdc54d674851851451c6c69c514ed1",
    "support"
   ],
   "interfaces/geometry.idl": [
    "b4c2837ade7a509306755eb7b682f6648c3684e3",
    "support"
   ],
   "interfaces/html.idl": [
-   "137e061bbab6b23150d6ae9128df56a96cd1d68f",
+   "7c77578dededdc99f2be1737373b9ebe59357938",
    "support"
   ],
   "interfaces/mediacapture-main.idl": [
    "3d59aebd6219a0312ade8c543bb389030d670d82",
    "support"
   ],
   "interfaces/remoteplayback.idl": [
    "f7c100f4275f2e32fbca3bb8d9c4900df879ffe4",
@@ -596412,17 +596412,17 @@
    "c1d1054447e116becb50aaf96aad00a25f0a6752",
    "testharness"
   ],
   "intersection-observer/shadow-content.html": [
    "11681640d5c8b2c62229ed5a717172f917d75ba4",
    "testharness"
   ],
   "intersection-observer/timestamp.html": [
-   "b9bf8d472d7751ec4a1ebee925d12668bedeee7a",
+   "0d57a6abc3c3056f921401f629ab231c458cf4cb",
    "testharness"
   ],
   "intersection-observer/unclipped-root.html": [
    "67dab96304c745f1b5462bb1074753b09d77fbd1",
    "testharness"
   ],
   "intersection-observer/zero-area-element-hidden.html": [
    "59d854e89ca0d7b035a87376566775ca2f3420e5",
@@ -616640,17 +616640,17 @@
    "55d32a5d2a362a2d7bd0ddc580fa24180f3d3579",
    "testharness"
   ],
   "selection/isCollapsed.html": [
    "d1984a9359d880dfb81197e7ec31b2456833809d",
    "testharness"
   ],
   "selection/removeAllRanges.html": [
-   "bd203d8878c4de59de476fe6fa7417bd2678dfcc",
+   "c1ed8afc2f1ee80f5131d1ead6930c9895a2a6f3",
    "testharness"
   ],
   "selection/removeRange.html": [
    "4a1ca00b32bca658f31bbff3f01a0d9154fb9779",
    "testharness"
   ],
   "selection/selectAllChildren.html": [
    "1951e6d34c7959c038146efde2d49a7898eaee29",
@@ -625076,37 +625076,37 @@
    "5ba51b660c7203bba3ada597c2f56fe094358e1f",
    "wdspec"
   ],
   "webdriver/tests/get_window_rect.py": [
    "2d4c13edc4e659af864750d0341c06ff969a687f",
    "wdspec"
   ],
   "webdriver/tests/maximize_window.py": [
-   "827b3a3e1a3ef628dae1480af029fc01ef5e9388",
+   "55cb76c60c7914bc024f470f6d1f0a47294b6fe3",
    "wdspec"
   ],
   "webdriver/tests/navigation.py": [
    "cec2987258d9c807a247da9e0216b3af1f171484",
    "wdspec"
   ],
   "webdriver/tests/set_window_rect.py": [
-   "8aef7d228fc9c1e8cf1029d8f1f7669602b6e877",
+   "061a8569a4c080a62ab9d7a00efa3c01a2223b74",
    "wdspec"
   ],
   "webdriver/tests/support/__init__.py": [
    "5a31a3917a5157516c10951a3b3d5ffb43b992d9",
    "support"
   ],
   "webdriver/tests/support/asserts.py": [
-   "e624c50e02a0da4d532321a080ecc5c73644bd8d",
+   "c6d7303efd64a6a632a1cd1eef10acf1d7de04cd",
    "support"
   ],
   "webdriver/tests/support/fixtures.py": [
-   "6ceec11f42cd9be53a92ad88aa07657c78779ce3",
+   "055884949ae77f5f1ac49d205c590344606dedfb",
    "support"
   ],
   "webdriver/tests/support/http_request.py": [
    "cb40c781fea2280b98135522def5e6a116d7b946",
    "support"
   ],
   "webdriver/tests/support/inline.py": [
    "bc85126e5637145e81f27d037f3a9090747130c8",
--- a/testing/web-platform/meta/webdriver/tests/set_window_rect.py.ini
+++ b/testing/web-platform/meta/webdriver/tests/set_window_rect.py.ini
@@ -3,12 +3,8 @@
   [set_window_rect.py::test_set_window_rect_prompt_accept]
     expected: FAIL
 
   [set_window_rect.py::test_set_window_rect_handle_prompt_missing_value]
     expected: FAIL
 
   [set_window_rect.py::test_set_window_fullscreen]
     expected: FAIL
-
-  [set_window_rect.py::test_set_window_rect_window_minimized]
-    expected: FAIL
-
--- a/testing/web-platform/tests/webdriver/tests/set_window_rect.py
+++ b/testing/web-platform/tests/webdriver/tests/set_window_rect.py
@@ -115,22 +115,26 @@ def test_set_window_fullscreen(session):
                             "width": 400.0,
                             "height": 400.0,
                             "state": "normal"})
 
 
 def test_set_window_rect_window_minimized(session):
     # step 11
     session.window.minimize()
-    assert session.execute_script("return document.hidden")
+    assert session.window.state == "minimized"
+
     result = session.transport.send("POST",
                                     "session/%s/window/rect" % session.session_id,
                                     {"width": 400, "height": 400})
     assert not session.execute_script("return document.hidden")
-    assert_success(result, {"width": 400, "height": 400})
+    rect = assert_success(result)
+    assert rect["width"] == 400
+    assert rect["height"] == 400
+    assert rect["state"] == "normal"
 
 
 def test_set_window_height_width(session):
     original = session.window.rect
 
     # step 12
     max = session.execute_script("""
         return {