Bug 1390432 - Get the right parent outline-width value during computation r?bholley draft
authorNazım Can Altınova <canaltinova@gmail.com>
Tue, 15 Aug 2017 00:15:41 -0700
changeset 646418 2476f9ba04237fc67a91992bd9ff6fab5b06a9bf
parent 646265 b95b1638db48fc3d450b95b98da6bcd2f9326d2f
child 726233 da228457946537a425f0994d3dfb0a4d0ccd08bc
push id74112
push userbmo:canaltinova@gmail.com
push dateTue, 15 Aug 2017 07:19:47 +0000
reviewersbholley
bugs1390432
milestone57.0a1
Bug 1390432 - Get the right parent outline-width value during computation r?bholley nsStyleOutline::RecalcData() method does a fixup to outline-width property and stores the new value inside mActualOutlineWidth. But during computation of outline data, we were still getting mOutlineWidth value instead of mActualOutlineWidth and it was causing to get the wrong inherited value. MozReview-Commit-ID: E7lrpceiXbD
layout/style/nsRuleNode.cpp
--- a/layout/style/nsRuleNode.cpp
+++ b/layout/style/nsRuleNode.cpp
@@ -7935,17 +7935,17 @@ nsRuleNode::ComputeOutlineData(void* aSt
                                const RuleDetail aRuleDetail,
                                const RuleNodeCacheConditions aConditions)
 {
   COMPUTE_START_RESET(Outline, outline, parentOutline)
 
   // outline-width: length, enum, inherit
   Maybe<nscoord> coord =
     ComputeLineWidthValue<eUnsetInitial>(
-      *aRuleData->ValueForOutlineWidth(), parentOutline->mOutlineWidth,
+      *aRuleData->ValueForOutlineWidth(), parentOutline->GetOutlineWidth(),
       nsPresContext::GetBorderWidthForKeyword(NS_STYLE_BORDER_WIDTH_MEDIUM),
       aContext, mPresContext, conditions);
   if (coord.isSome()) {
     outline->mOutlineWidth = *coord;
   }
 
   // outline-offset: length, inherit
   nsStyleCoord tempCoord;