Bug 1369317 - Do not escape the returned string in nsSimpleURI::GetAsciiSpec r=mcmanus
The spec is already escaped in SetSpec,SetQuery,SetRef - so there is no need to escape it again in the getter.
MozReview-Commit-ID: C0279q5nLXl
--- a/netwerk/base/nsSimpleURI.cpp
+++ b/netwerk/base/nsSimpleURI.cpp
@@ -690,22 +690,22 @@ nsSimpleURI::CloneInternal(nsSimpleURI::
NS_IMETHODIMP
nsSimpleURI::Resolve(const nsACString &relativePath, nsACString &result)
{
result = relativePath;
return NS_OK;
}
NS_IMETHODIMP
-nsSimpleURI::GetAsciiSpec(nsACString &result)
+nsSimpleURI::GetAsciiSpec(nsACString &aResult)
{
- nsAutoCString buf;
- nsresult rv = GetSpec(buf);
+ nsresult rv = GetSpec(aResult);
if (NS_FAILED(rv)) return rv;
- return NS_EscapeURL(buf, esc_OnlyNonASCII|esc_AlwaysCopy, result, fallible);
+ MOZ_ASSERT(IsASCII(aResult), "The spec should be ASCII");
+ return NS_OK;
}
NS_IMETHODIMP
nsSimpleURI::GetAsciiHostPort(nsACString &result)
{
// XXX This behavior mimics GetHostPort.
return NS_ERROR_FAILURE;
}