Bug 1389851 - build: Enable clang's -Wunreachable-code-return warnings. r?glandium draft
authorChris Peterson <cpeterson@mozilla.com>
Tue, 08 Aug 2017 23:12:41 -0700
changeset 647398 8ff17eaae2cbb6a33ee564b7ba5f15c595896da8
parent 647397 10ba9718daf33227ad31b9453536a352c07efe0b
child 726479 29dce5b34ce2d33cd1100b21725bd7d595078333
push id74381
push usercpeterson@mozilla.com
push dateWed, 16 Aug 2017 08:08:22 +0000
reviewersglandium
bugs1389851
milestone57.0a1
Bug 1389851 - build: Enable clang's -Wunreachable-code-return warnings. r?glandium MozReview-Commit-ID: 8Zl0mbzcFBm
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -37,16 +37,17 @@ add_gcc_warning('-Wpointer-arith')
 # catches comparing signed/unsigned ints
 add_gcc_warning('-Wsign-compare')
 
 # catches overflow bugs, few false positives
 add_gcc_warning('-Wtype-limits')
 
 # catches some dead code
 add_gcc_warning('-Wunreachable-code')
+check_and_add_gcc_warning('-Wunreachable-code-return')
 
 # catches treating string literals as non-const
 add_gcc_warning('-Wwrite-strings', cxx_compiler)
 
 # turned on by -Wall, but we use offsetof on non-POD types frequently
 add_gcc_warning('-Wno-invalid-offsetof', cxx_compiler)
 
 # catches objects passed by value to variadic functions.