Bug 1382332: Remove duplicate URLs from AS top sites. r=grisha draft
authorMichael Comella <michael.l.comella@gmail.com>
Thu, 10 Aug 2017 18:27:15 -0700
changeset 646234 1f6579c74d1e8a9dede0ce07d739d4bbe2ddac83
parent 646233 be57f0b3618d33ec34e23e3b5c7e343aca65425e
child 646253 0a3aa337545539437ff2a046216d8178bdabccca
push id74034
push usermichael.l.comella@gmail.com
push dateTue, 15 Aug 2017 00:29:50 +0000
reviewersgrisha
bugs1382332
milestone57.0a1
Bug 1382332: Remove duplicate URLs from AS top sites. r=grisha MozReview-Commit-ID: E9dP9IitXQQ
mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
--- a/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
+++ b/mobile/android/base/java/org/mozilla/gecko/db/BrowserProvider.java
@@ -1213,16 +1213,18 @@ public class BrowserProvider extends Sha
                     PageMetadata.JSON + " AS " + TopSites.PAGE_METADATA_JSON +
 
                     " FROM (" + selectTopSites + ") AS " + TABLE_TOPSITES +
 
                     " LEFT OUTER JOIN " + TABLE_PAGE_METADATA + " ON " +
                             DBUtils.qualifyColumn(TABLE_TOPSITES, Combined.HISTORY_GUID) + " = " +
                             DBUtils.qualifyColumn(TABLE_PAGE_METADATA, PageMetadata.HISTORY_GUID) +
 
+                    " GROUP BY " + DBUtils.qualifyColumn(TABLE_TOPSITES, Bookmarks.URL) + // remove duplicates.
+
                     // In case position is non-unique (as in Activity Stream pins, whose position
                     // is always zero), we need to ensure we get stable ordering.
                     " ORDER BY " + Bookmarks.POSITION + ", " + Bookmarks.URL,
 
                     null);
 
             c.setNotificationUri(getContext().getContentResolver(),
                                  BrowserContract.AUTHORITY_URI);