Bug 1388692 - Make GeckoRestyleManager::UpdateAnimationStyles() private. r?birtles draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Mon, 14 Aug 2017 20:00:04 +0900
changeset 645857 25e20ad3fde5f0642f23cc17764a11ca4cd1e375
parent 645856 87c83e3d7e8008a58a18a23c95b07469db812d2c
child 726051 3fbc80ea92ab620c0e47a51988e0e6f70acc3233
push id73912
push userhikezoe@mozilla.com
push dateMon, 14 Aug 2017 11:00:28 +0000
reviewersbirtles
bugs1388692
milestone57.0a1
Bug 1388692 - Make GeckoRestyleManager::UpdateAnimationStyles() private. r?birtles It's only used inside the class. MozReview-Commit-ID: IrIUwrDkUCB
layout/base/GeckoRestyleManager.h
--- a/layout/base/GeckoRestyleManager.h
+++ b/layout/base/GeckoRestyleManager.h
@@ -211,17 +211,16 @@ public:
 
 private:
   // ProcessPendingRestyles calls into one of our RestyleTracker
   // objects.  It then calls back to these functions at the beginning
   // and end of its work.
   void BeginProcessingRestyles(RestyleTracker& aRestyleTracker);
   void EndProcessingRestyles();
 
-public:
   // Perform any pending animation restyles.
   //
   // This is a superset of the work performed by
   // UpdateAnimationStylesForHitTesting since it includes not only any
   // animations whose restyles might have been suppressed on the main thread
   // because they are running on the compositor, but *any* animations with
   // pending restyles including SMIL animation restyles.
   //
@@ -235,16 +234,18 @@ public:
   // we need to have an up-to-date *old* value of the property on the
   // primary frame.  So the purpose of the mini-flush is to update the
   // style for all throttled transitions and animations to the current
   // animation state without making any other updates, so that when we
   // process the queued style updates we'll have correct old data to
   // compare against.  When we do this, we don't bother touching frames
   // other than primary frames.
   void UpdateAnimationStyles();
+
+public:
   void UpdateAnimationStylesForHitTesting();
 
   // Rebuilds all style data by throwing out the old rule tree and
   // building a new one, and additionally applying aExtraHint (which
   // must not contain nsChangeHint_ReconstructFrame) to the root frame.
   //
   // aRestyleHint says which restyle hint to use for the computation;
   // the only sensible values to use are eRestyle_Subtree (which says