Bug 1388943 - Include logical properties in has_author_specified_rules ; r?heycam
MozReview-Commit-ID: IJtsshfDIHs
--- a/layout/reftests/native-theme/reftest.list
+++ b/layout/reftests/native-theme/reftest.list
@@ -7,17 +7,17 @@
!= listbox-not-blank.html about:blank
!= radio-not-blank.html about:blank
!= text-control-not-blank.html about:blank
!= textarea-not-blank.html about:blank
# The following tests will fail if the platform does not have native
# theme support (which all platforms should have).
fails-if(!nativeThemePref) != text-input-native.html text-input-nonnative.html
-fuzzy-if(skiaContent,2,88) fails-if(styloVsGecko||stylo) == text-input-nonnative-when-styled.html text-input-nonnative-when-styled-ref.html
+fuzzy-if(skiaContent,2,88) == text-input-nonnative-when-styled.html text-input-nonnative-when-styled-ref.html
fails-if(!nativeThemePref) != textarea-native.html textarea-nonnative.html
fuzzy-if(skiaContent,2,53) == textarea-nonnative-when-styled.html textarea-nonnative-when-styled-ref.html
fails-if(!nativeThemePref) != button-native.html button-nonnative.html
== button-nonnative-when-styled.html button-nonnative-when-styled-ref.html
fails-if(!nativeThemePref&&!Android) != combobox-native.html combobox-nonnative.html
== combobox-nonnative-when-styled.html combobox-nonnative-when-styled-ref.html
fails-if(!nativeThemePref) needs-focus != listbox-native.html listbox-nonnative.html
needs-focus == listbox-nonnative-when-styled.html listbox-nonnative-when-styled-ref.html
--- a/servo/components/style/rule_tree/mod.rs
+++ b/servo/components/style/rule_tree/mod.rs
@@ -1075,23 +1075,41 @@ impl StrongRuleNode {
LonghandId::BorderBottomWidth,
LonghandId::BorderLeftColor,
LonghandId::BorderLeftStyle,
LonghandId::BorderLeftWidth,
LonghandId::BorderTopLeftRadius,
LonghandId::BorderTopRightRadius,
LonghandId::BorderBottomRightRadius,
LonghandId::BorderBottomLeftRadius,
+
+ LonghandId::BorderInlineStartColor,
+ LonghandId::BorderInlineStartStyle,
+ LonghandId::BorderInlineStartWidth,
+ LonghandId::BorderInlineEndColor,
+ LonghandId::BorderInlineEndStyle,
+ LonghandId::BorderInlineEndWidth,
+ LonghandId::BorderBlockStartColor,
+ LonghandId::BorderBlockStartStyle,
+ LonghandId::BorderBlockStartWidth,
+ LonghandId::BorderBlockEndColor,
+ LonghandId::BorderBlockEndStyle,
+ LonghandId::BorderBlockEndWidth,
];
const PADDING_PROPS: &'static [LonghandId] = &[
LonghandId::PaddingTop,
LonghandId::PaddingRight,
LonghandId::PaddingBottom,
LonghandId::PaddingLeft,
+
+ LonghandId::PaddingInlineStart,
+ LonghandId::PaddingInlineEnd,
+ LonghandId::PaddingBlockStart,
+ LonghandId::PaddingBlockEnd,
];
// Inherited properties:
const TEXT_SHADOW_PROPS: &'static [LonghandId] = &[
LonghandId::TextShadow,
];
fn inherited(id: LonghandId) -> bool {
@@ -1126,16 +1144,20 @@ impl StrongRuleNode {
// rules if we're looking at a non-color property or if we're looking at
// the background color and it's set to transparent.
const IGNORED_WHEN_COLORS_DISABLED: &'static [LonghandId] = &[
LonghandId::BackgroundImage,
LonghandId::BorderTopColor,
LonghandId::BorderRightColor,
LonghandId::BorderBottomColor,
LonghandId::BorderLeftColor,
+ LonghandId::BorderInlineStartColor,
+ LonghandId::BorderInlineEndColor,
+ LonghandId::BorderBlockStartColor,
+ LonghandId::BorderBlockEndColor,
LonghandId::TextShadow,
];
if !author_colors_allowed {
for id in IGNORED_WHEN_COLORS_DISABLED {
properties.remove(*id);
}
}