Bug 1362338: Manually whitelist nsIAtom::Release in the root analysis. r?sfink draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 10 Aug 2017 12:20:10 +0200
changeset 644038 d4f0fa5ed2f7065caeb82734661f99e64908be36
parent 644037 5c96958bb34850208723b712d876d2b7f9e10eaa
child 725470 652a9d40dae627f3755be3617d50fb5bdd033c29
push id73285
push userbmo:emilio+bugs@crisal.io
push dateThu, 10 Aug 2017 10:21:41 +0000
reviewerssfink
bugs1362338
milestone57.0a1
Bug 1362338: Manually whitelist nsIAtom::Release in the root analysis. r?sfink This is the only approach that I managed to make work. MozReview-Commit-ID: CUnkDoYN3di
js/src/devtools/rootAnalysis/annotations.js
--- a/js/src/devtools/rootAnalysis/annotations.js
+++ b/js/src/devtools/rootAnalysis/annotations.js
@@ -165,16 +165,17 @@ var ignoreFunctions = {
     "uint8 NS_IsMainThread()" : true,
 
     // Has an indirect call under it by the name "__f", which seemed too
     // generic to ignore by itself.
     "void* std::_Locale_impl::~_Locale_impl(int32)" : true,
 
     // Bug 1056410 - devirtualization prevents the standard nsISupports::Release heuristic from working
     "uint32 nsXPConnect::Release()" : true,
+    "uint32 nsIAtom::Release()" : true,
 
     // Allocation API
     "malloc": true,
     "calloc": true,
     "realloc": true,
     "free": true,
 
     // FIXME!