Bug 1388233 - Use &brandShortName; instead of hard-coded 'Firefox'. draft
authorHenry Chang <hchang@mozilla.com>
Thu, 17 Aug 2017 10:18:37 +0800
changeset 647915 b69bb5e622159974fb05a264616d16d766452431
parent 647817 63ca686c3f1e870649b6d9c559973d100573aec2
child 726668 928007a89ed0b35fd3e089140465f22c2353477d
push id74582
push userhchang@mozilla.com
push dateThu, 17 Aug 2017 03:08:58 +0000
bugs1388233
milestone57.0a1
Bug 1388233 - Use &brandShortName; instead of hard-coded 'Firefox'. MozReview-Commit-ID: 271t5IDUzIR
browser/base/content/blockedSite.xhtml
browser/locales/en-US/chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd
--- a/browser/base/content/blockedSite.xhtml
+++ b/browser/base/content/blockedSite.xhtml
@@ -125,18 +125,16 @@
           el.remove();
         }
 
         if (error !== "harmful") {
           el = document.getElementById("errorTitleText_harmful");
           el.remove();
           el = document.getElementById("errorShortDescText_harmful");
           el.remove();
-          el = document.getElementById("errorLongDescText_harmful");
-          el.remove();
         }
 
         // Set sitename if necessary.
         let sitenameElem = document.getElementById(error + "_sitename");
         if (sitenameElem) {
           sitenameElem.textContent = getHostString();
         }
 
@@ -170,25 +168,24 @@
 
       <div id="errorLongContent">
 
         <!-- Short Description -->
         <div id="errorShortDesc">
           <p id="errorShortDescText_phishing">&safeb.blocked.phishingPage.shortDesc2;</p>
           <p id="errorShortDescText_malware">&safeb.blocked.malwarePage.shortDesc;</p>
           <p id="errorShortDescText_unwanted">&safeb.blocked.unwantedPage.shortDesc;</p>
-          <p id="errorShortDescText_harmful">&safeb.blocked.harmfulPage.shortDesc;</p>
+          <p id="errorShortDescText_harmful">&safeb.blocked.harmfulPage.shortDesc2;</p>
         </div>
 
         <!-- Long Description -->
         <div id="errorLongDesc">
           <p id="errorLongDescText_phishing">&safeb.blocked.phishingPage.longDesc2;</p>
           <p id="errorLongDescText_malware">&safeb.blocked.malwarePage.longDesc;</p>
           <p id="errorLongDescText_unwanted">&safeb.blocked.unwantedPage.longDesc;</p>
-          <p id="errorLongDescText_harmful">&safeb.blocked.harmfulPage.longDesc;</p>
         </div>
 
         <!-- Advisory -->
         <div id="advisoryDesc">
           <p id="advisoryDescText">&safeb.palm.advisory.desc;</p>
         </div>
 
         <!-- Action buttons -->
--- a/browser/locales/en-US/chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd
+++ b/browser/locales/en-US/chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd
@@ -28,11 +28,9 @@
 <!ENTITY safeb.blocked.unwantedPage.longDesc "<p>Unwanted software pages try to install software that can be deceptive and affect your system in unexpected ways.</p>">
 
 <!ENTITY safeb.blocked.phishingPage.title2 "Deceptive Site!">
 <!-- Localization note (safeb.blocked.phishingPage.shortDesc2) - Please don't translate the contents of the <span id="phishing_sitename"/> tag. It will be replaced at runtime with a domain name (e.g. www.badsite.com) -->
 <!ENTITY safeb.blocked.phishingPage.shortDesc2 "This web page at <span id='phishing_sitename'/> has been reported as a deceptive site and has been blocked based on your security preferences.">
 <!ENTITY safeb.blocked.phishingPage.longDesc2 "<p>Deceptive sites are designed to trick you into doing something dangerous, like installing software, or revealing your personal information, like passwords, phone numbers or credit cards.</p><p>Entering any information on this web page may result in identity theft or other fraud.</p>">
 
 <!ENTITY safeb.blocked.harmfulPage.title "The site ahead may contain malware">
-<!-- Localization note (safeb.blocked.harmfulPage.shortDesc) - Please don't translate the contents of the <span id="harmful_sitename"/> tag. It will be replaced at runtime with a domain name (e.g. www.badsite.com) -->
-<!ENTITY safeb.blocked.harmfulPage.shortDesc "Firefox blocked this page because it might try to install dangerous apps that steal or delete your information (for example, photos, passwords, messages and credit cards).">
-<!ENTITY safeb.blocked.harmfulPage.longDesc "">
\ No newline at end of file
+<!ENTITY safeb.blocked.harmfulPage.shortDesc2 "&brandShortName; blocked this page because it might try to install dangerous apps that steal or delete your information (for example, photos, passwords, messages and credit cards).">
\ No newline at end of file