WIP: ASTReader is code complete! draft
authorDavid Teller <dteller@mozilla.com>
Sun, 06 Aug 2017 22:43:39 +0200
changeset 641395 ae29364668dbfb5d4e4bd3c06ef855d9c1a0f87a
parent 641394 29291630cfc06396cb2efc88d660e8f766b17d7d
child 654868 8267b2ad62f6c6b494159ee950cbed1b8bccae06
push id72504
push userdteller@mozilla.com
push dateSun, 06 Aug 2017 22:28:40 +0000
milestone57.0a1
WIP: ASTReader is code complete! MozReview-Commit-ID: 42WpTVKqVre
js/src/frontend/BinSource.cpp
--- a/js/src/frontend/BinSource.cpp
+++ b/js/src/frontend/BinSource.cpp
@@ -2622,16 +2622,31 @@ ASTReader::parseKeyValueList(SimpleToken
 }
 
 bool
 ASTReader::readString(SimpleTokenReader* reader, MutableHandleString out) {
     if (out) {
         return this->raiseError();
     }
 
+    RootedAtom atom(this->cx);
+    if (!this->readString(reader, &atom)) {
+        return false;
+    }
+
+    out.set(atom);
+    return true;
+}
+
+bool
+ASTReader::readString(SimpleTokenReader* reader, MutableHandleAtom out) {
+    if (out) {
+        return this->raiseError();
+    }
+
     Maybe<std::string> string;
     if (!this->readString(reader, string)) {
         return false;
     }
 
     if (!string) {
         return true;
     }