Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7) r?gcp draft
authorSylvestre Ledru <sledru@mozilla.com>
Sun, 06 Aug 2017 19:06:36 +0200
changeset 649493 ce412362265bced356e509e1c28059b3d6d9f688
parent 649492 819c35ea7b045ffca51750be695e929ca22e0219
child 649494 88e6580da251c2c9374ae8050a1ebcb1f65294c7
push id75042
push userbmo:sledru@mozilla.com
push dateSat, 19 Aug 2017 19:56:47 +0000
reviewersgcp
bugs1387569
milestone57.0a1
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc for a chromium file (exists from gcc 7) r?gcp MozReview-Commit-ID: cuQuFcAnWL
security/sandbox/linux/moz.build
--- a/security/sandbox/linux/moz.build
+++ b/security/sandbox/linux/moz.build
@@ -78,17 +78,17 @@ if CONFIG['MOZ_GMP_SANDBOX']:
     ]
 
 # This copy of SafeSPrintf doesn't need to avoid the Chromium logging
 # dependency like the one in libxul does, but this way the behavior is
 # consistent.  See also the comment in SandboxLogging.h.
 SOURCES['../chromium/base/strings/safe_sprintf.cc'].flags += ['-DNDEBUG']
 
 # Keep clang from warning about intentional 'switch' fallthrough in icu_utf.cc:
-if CONFIG['CLANG_CXX']:
+if CONFIG['CLANG_CXX'] or CONFIG['GNU_CXX']:
     SOURCES['../chromium/base/third_party/icu/icu_utf.cc'].flags += ['-Wno-implicit-fallthrough']
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wno-shadow']
     SOURCES['../chromium/sandbox/linux/services/syscall_wrappers.cc'].flags += [
         '-Wno-empty-body',
     ]