Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7) r?ted draft
authorSylvestre Ledru <sledru@mozilla.com>
Sat, 19 Aug 2017 21:50:09 +0200
changeset 649492 819c35ea7b045ffca51750be695e929ca22e0219
parent 621429 09b8dbf068471136b7d2966d709d5b595d3b5f07
child 649493 ce412362265bced356e509e1c28059b3d6d9f688
push id75042
push userbmo:sledru@mozilla.com
push dateSat, 19 Aug 2017 19:56:47 +0000
reviewersted
bugs1387569
milestone57.0a1
Bug 1387569 - Also enable -Wno-implicit-fallthrough for gcc in google-breakpad (exists from gcc 7) r?ted MozReview-Commit-ID: HTEL8UJE6wb
toolkit/crashreporter/crashreporter.mozbuild
--- a/toolkit/crashreporter/crashreporter.mozbuild
+++ b/toolkit/crashreporter/crashreporter.mozbuild
@@ -25,17 +25,21 @@ elif CONFIG['GNU_CXX']:
         '-Wno-unused-local-typedefs',
         '-Wno-shadow',
         '-Wno-deprecated-declarations',
         '-Wno-bool-compare',
         '-Wno-unused-but-set-variable',
     ]
 
 if CONFIG['CLANG_CXX'] or CONFIG['CLANG_CL']:
-    CXXFLAGS += [
-        '-Wno-implicit-fallthrough',
-        '-Wno-c++11-narrowing',
-    ]
+     CXXFLAGS += [
+         '-Wno-c++11-narrowing',
+     ]
+
+if not CONFIG['_MSC_VER']:
+     CXXFLAGS += [
+         '-Wno-implicit-fallthrough',
+     ]
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
     DEFINES['ELFSIZE'] = 32
 
 DEFINES['NO_STABS_SUPPORT'] = True