Bug 1387532 - Enforce that we don't schedule multiple chunks for the same test without passing buildbot the required chunking information. r=catlee draft
authorJustin Wood <Callek@gmail.com>
Fri, 04 Aug 2017 13:59:14 -0400
changeset 621330 6a043c5da4675b00fb9061ddba2e383f05f89d33
parent 621329 bb234d41c28875842f60cf192d184ca8fad316d6
child 640978 164899490624cde0fd884aabb968d38b288bc118
push id72340
push userCallek@gmail.com
push dateFri, 04 Aug 2017 18:03:50 +0000
reviewerscatlee
bugs1387532
milestone57.0a1
Bug 1387532 - Enforce that we don't schedule multiple chunks for the same test without passing buildbot the required chunking information. r=catlee The issue here is that we had marked 'chunked' as false, but were still trying to use 8 chunks for reftest. Because of this we were also sending the unchunked buildbot name to BBB for each chunk we actually tried to run, on e10s and other variants. MozReview-Commit-ID: Dc5npIq5sxr
taskcluster/taskgraph/transforms/job/mozharness_test.py
--- a/taskcluster/taskgraph/transforms/job/mozharness_test.py
+++ b/taskcluster/taskgraph/transforms/job/mozharness_test.py
@@ -463,16 +463,19 @@ def mozharness_test_buildbot_bridge(conf
         ])
 
     # in buildbot, mochitest-webgl is called mochitest-gl
     test_name = test_name.replace('webgl', 'gl')
 
     if mozharness.get('chunked', False):
         this_chunk = test.get('this-chunk')
         test_name = '{}-{}'.format(test_name, this_chunk)
+    elif test.get('this-chunk', 1) != 1:
+        raise Exception("Unexpected chunking when 'chunked' attribute is 'false'"
+                        " for {}".format(test_name))
 
     if test.get('suite', '') == 'talos':
         variant = get_variant(test['test-platform'])
 
         # On beta and release, we run nightly builds on-push; the talos
         # builders need to run against non-nightly buildernames
         if variant == 'nightly':
             variant = ''