Bug 1383505 - add test to make sure onboarding show the first uncomplete tour by default;r=mossop,fischer draft
authorgasolin <gasolin@gmail.com>
Thu, 03 Aug 2017 10:18:11 +0800
changeset 620136 a4e392085e927790e9f293152435d4aa106e7242
parent 620098 568e9e8807d498beec534a45496ad9a9cb7af234
child 640595 578fc70ff03413ce349f251424f89354a3c8e3df
push id71928
push userbmo:gasolin@mozilla.com
push dateThu, 03 Aug 2017 04:09:26 +0000
reviewersmossop, fischer
bugs1383505
milestone57.0a1
Bug 1383505 - add test to make sure onboarding show the first uncomplete tour by default;r=mossop,fischer MozReview-Commit-ID: APOBLLS6Pga
browser/extensions/onboarding/test/browser/browser_onboarding_select_default_tour.js
--- a/browser/extensions/onboarding/test/browser/browser_onboarding_select_default_tour.js
+++ b/browser/extensions/onboarding/test/browser/browser_onboarding_select_default_tour.js
@@ -18,25 +18,23 @@ add_task(async function test_first_tour_
     ["browser.onboarding.newtour", "private,addons,customize"],
   ]});
 
   let tab = await openTab(ABOUT_NEWTAB_URL);
   await promiseOnboardingOverlayLoaded(tab.linkedBrowser);
   await BrowserTestUtils.synthesizeMouseAtCenter(OVERLAY_ICON_ID, {}, tab.linkedBrowser);
   await promiseOnboardingOverlayOpened(tab.linkedBrowser);
 
-  await ContentTask.spawn(tab.linkedBrowser, {}, () => {
-    let doc = content.document;
-    let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
-    ok(dom.classList.contains(CLASS_ACTIVE));
-    let dom2 = doc.querySelector(ADDONS_TOUR_ID);
-    ok(!dom2.classList.contains(CLASS_ACTIVE));
-    let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
-    ok(!dom3.classList.contains(CLASS_ACTIVE));
-  });
+  let doc = content && content.document;
+  let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
+  ok(dom.classList.contains(CLASS_ACTIVE));
+  let dom2 = doc.querySelector(ADDONS_TOUR_ID);
+  ok(!dom2.classList.contains(CLASS_ACTIVE));
+  let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
+  ok(!dom3.classList.contains(CLASS_ACTIVE));
 
   await BrowserTestUtils.removeTab(tab);
 });
 
 add_task(async function test_select_first_uncomplete_tour() {
   resetOnboardingDefaultState();
   await SpecialPowers.pushPrefEnv({set: [
     ["browser.onboarding.tour-type", "new"],
@@ -44,26 +42,25 @@ add_task(async function test_select_firs
     ["browser.onboarding.seen-tourset-version", 1],
     ["browser.onboarding.newtour", "private,addons,customize"],
   ]});
   setTourCompletedState("onboarding-tour-private-browsing", true);
 
   let tab = await openTab(ABOUT_NEWTAB_URL);
   await promiseOnboardingOverlayLoaded(tab.linkedBrowser);
   await BrowserTestUtils.synthesizeMouseAtCenter(OVERLAY_ICON_ID, {}, tab.linkedBrowser);
-  await promiseOnboardingOverlayOpened(tab.linkedBrowser);  
-  await ContentTask.spawn(tab.linkedBrowser, {}, () => {
-    let doc = content.document;
-    let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
-    ok(!dom.classList.contains(CLASS_ACTIVE));
-    let dom2 = doc.querySelector(ADDONS_TOUR_ID);
-    ok(dom2.classList.contains(CLASS_ACTIVE));
-    let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
-    ok(!dom3.classList.contains(CLASS_ACTIVE));
-  });
+  await promiseOnboardingOverlayOpened(tab.linkedBrowser);
+
+  let doc = content && content.document;
+  let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
+  ok(!dom.classList.contains(CLASS_ACTIVE));
+  let dom2 = doc.querySelector(ADDONS_TOUR_ID);
+  ok(dom2.classList.contains(CLASS_ACTIVE));
+  let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
+  ok(!dom3.classList.contains(CLASS_ACTIVE));
 
   await BrowserTestUtils.removeTab(tab);
 });
 
 add_task(async function test_select_first_tour_when_all_tours_are_complete() {
   resetOnboardingDefaultState();
   await SpecialPowers.pushPrefEnv({set: [
     ["browser.onboarding.tour-type", "new"],
@@ -73,21 +70,20 @@ add_task(async function test_select_firs
   ]});
   setTourCompletedState("onboarding-tour-private-browsing", true);
   setTourCompletedState("onboarding-tour-addons", true);
   setTourCompletedState("onboarding-tour-customize", true);
 
   let tab = await openTab(ABOUT_NEWTAB_URL);
   await promiseOnboardingOverlayLoaded(tab.linkedBrowser);
   await BrowserTestUtils.synthesizeMouseAtCenter(OVERLAY_ICON_ID, {}, tab.linkedBrowser);
-  await promiseOnboardingOverlayOpened(tab.linkedBrowser);  
-  await ContentTask.spawn(tab.linkedBrowser, {}, () => {
-    let doc = content.document;
-    let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
-    ok(dom.classList.contains(CLASS_ACTIVE));
-    let dom2 = doc.querySelector(ADDONS_TOUR_ID);
-    ok(!dom2.classList.contains(CLASS_ACTIVE));
-    let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
-    ok(!dom3.classList.contains(CLASS_ACTIVE));
-  });
+  await promiseOnboardingOverlayOpened(tab.linkedBrowser);
+
+  let doc = content && content.document;
+  let dom = doc.querySelector(PRIVATE_BROWSING_TOUR_ID);
+  ok(dom.classList.contains(CLASS_ACTIVE));
+  let dom2 = doc.querySelector(ADDONS_TOUR_ID);
+  ok(!dom2.classList.contains(CLASS_ACTIVE));
+  let dom3 = doc.querySelector(CUSTOMIZE_TOUR_ID);
+  ok(!dom3.classList.contains(CLASS_ACTIVE));
 
   await BrowserTestUtils.removeTab(tab);
 });