Bug 1385744 - Stop using a cache for the llvm source. r?gps draft
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 02 Aug 2017 15:28:11 +0900
changeset 619687 d2128d45f88f9878d548cd7f0cd04d2c20bd125a
parent 619524 4bedbaac7933d5c9e1f284c818ff71ffa681ff22
child 619688 f2486093e2a3517ea12084eeddc24475fdd04260
push id71775
push userbmo:mh+mozilla@glandium.org
push dateWed, 02 Aug 2017 12:32:51 +0000
reviewersgps
bugs1385744
milestone56.0a1
Bug 1385744 - Stop using a cache for the llvm source. r?gps The build-clang script doesn't handle properly updating the svn tree when it already exists and the svn url changed (which happens when using different branches), so if a clang job somehow gets a host that happen to have run another clang job before, it may not actually build what was intended to be built. That event, however, is rather rare, because clang jobs don't happen regularly enough. Fast iterations on try can cause the problem to appear, though. The former makes the use of a cache kind of useless, and the latter barely benefits from the cache anyways. So let's just solve this the easy way and remove the use of the cache. The alternative would be to fiddle with svn switch, and I don't really feel like it. Eventually, those jobs should use some other source than svn anyways, one that is more verifiable (tarballs for releases, and the git mirrors for trunk).
taskcluster/taskgraph/transforms/job/toolchain.py
--- a/taskcluster/taskgraph/transforms/job/toolchain.py
+++ b/taskcluster/taskgraph/transforms/job/toolchain.py
@@ -152,26 +152,16 @@ def windows_toolchain(config, job, taskd
     worker['artifacts'] = [{
         'path': r'public\build',
         'type': 'directory',
     }]
     worker['chain-of-trust'] = True
 
     docker_worker_add_gecko_vcs_env_vars(config, job, taskdesc)
 
-    # We fetch LLVM SVN into this.
-    svn_cache = 'level-{}-toolchain-clang-cl-build-svn'.format(config.params['level'])
-    worker['mounts'] = [{
-        'cache-name': svn_cache,
-        'directory': r'llvm-sources',
-    }]
-    taskdesc['scopes'].extend([
-        'generic-worker:cache:' + svn_cache,
-    ])
-
     env = worker['env']
     env.update({
         'MOZ_BUILD_DATE': config.params['moz_build_date'],
         'MOZ_SCM_LEVEL': config.params['level'],
         'MOZ_AUTOMATION': '1',
     })
 
     hg = r'c:\Program Files\Mercurial\hg.exe'